From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80338 invoked by alias); 23 Aug 2018 20:04:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80325 invoked by uid 89); 23 Aug 2018 20:04:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=dark, H*F:U*tom, Pedro's, Hx-languages-length:1290 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Aug 2018 20:03:59 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 36DC786A76 for ; Thu, 23 Aug 2018 15:03:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id svpFfX1TWBcCXsvpYf2h9O; Thu, 23 Aug 2018 15:03:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GwEiH5SP8np2z7PBbOeer98aiiK0yKThLpYeYzrYbP0=; b=gKAlOXGKLvBG5Zy+RrmEVbkcsP dk6hJtPGoiX9BVg94+/EESHnvz7d415lCR8dQhKGmkEc67OQyamiQ1wWuJEwTNtfANV3tr8nbhBF5 FCnkyZdJDEQc08m8X5WvC92/D; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44632 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fsvpF-002oGu-Hk; Thu, 23 Aug 2018 15:03:25 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, roirand@adacore.com Subject: Re: [RFC] Make "run" work on macOS 10.13 References: <20180629205532.25377-1-tom@tromey.com> Date: Thu, 23 Aug 2018 20:04:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 23 Aug 2018 12:01:24 -0400") Message-ID: <8736v43l6b.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00580.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> { >> + /* Starting with Sierra, SIP prevents gdb from attaching to the >> + shell, so users have to disable startup-with-shell. */ >> + scoped_restore save_startup >> + = make_scoped_restore (&startup_with_shell, 0); >> + >> /* Do the hard work. */ >> fork_inferior (exec_file, allargs, env, darwin_ptrace_me, Simon> I think this part is good. I would suggest printing a Simon> message/warnings to indicate that we are disabling startup-with-shell Simon> (only if startup_with_shell is 1 in the first place). See the bug and also Pedro's comments on Xavier's similar patch -- there are other, probably better, ideas here. Simon> The unrelocated value of the symbol is 0xf782. That breakpoint is Simon> used for "set stop-on-solib-events", it seems, so I tried to enable Simon> that with both of your patches. I got a stop with Xavier's patch and Simon> none with Tom's, which leads me to think that Xavier's patch gets it Simon> right. I think you may be using the executable base address, while we Simon> actually want to use dyld's base address? This is not very clear to Simon> me yet. I think we want Xavier's patch and not mine. Mine was more of a stab in the dark. Tom