From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48982 invoked by alias); 16 Sep 2018 12:16:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47091 invoked by uid 89); 16 Sep 2018 12:16:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=About, Hx-languages-length:952 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.187.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 12:16:49 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 9957F4010DDDC for ; Sun, 16 Sep 2018 06:21:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1VyDgJrYYbXuJ1VyXgc9an; Sun, 16 Sep 2018 07:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oOIlpN2KEe5nrBaGlK5je1UCj3N61cI7lNhywaAVI3I=; b=EzX4dSXb9Ej2lYs/weekCXxcLL 1ZCanrCTuJiH3/9sPpmi5xlaqEx5u1rlY4JFcV+BUrx+5zSr5V5/FakA1FEoQOUVmZ0lTmYpbUM4X rzL1qTvhdmDR5d0oDmKlg8Mwd; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:46064 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1VyD-003pt8-0m; Sun, 16 Sep 2018 07:16:09 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb References: <20180915025522.18723-1-tom@tromey.com> <20180915025522.18723-3-tom@tromey.com> Date: Sun, 16 Sep 2018 12:16:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 15 Sep 2018 23:20:28 -0400") Message-ID: <8736u9r62f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00532.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-09-14 10:55 p.m., Tom Tromey wrote: >> I searched for other spots that did not use the GNU style for >> metasyntactic syntactic variables. This patch fixes most of the ones >> I found in gdb proper. There are a few remaining in MI, but I was >> unsure whether those should be touched. Simon> About MI, I don't see why it should be different. Do you have specific Simon> examples? if (argc < 1) error (_("USAGE: %s [ [...]]"), command); But there are several if you search for [<][a-z][a-z-]*[>] Simon> I stumbled on some messages like this: Simon> error (_("-environment-cd: Usage DIRECTORY")); Simon> That looks confusing to me, I would much prefer Simon> error (_("Usage: -environment-cd DIRECTORY")); Agreed. Which reminds me that my gdb CLI usage quest is also incomplete. Tom