From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87955 invoked by alias); 5 Aug 2019 17:43:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87945 invoked by uid 89); 5 Aug 2019 17:43:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Aug 2019 17:43:14 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 54B309FA090 for ; Mon, 5 Aug 2019 12:43:12 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uh0qhrtnV2qH7uh0qhsvaH; Mon, 05 Aug 2019 12:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=11XJP6N3sNlKN+MOgyQAIPxzPE4y46jLDzJPHjN7tn8=; b=dIkIGQfV7Hw7JR6SW4Zw9QkUPJ b3Rvm9LvAiNzdXramfMQYJFxMEjJGnJOjyboVDQTru+qq7LdgAY9yMYi51Z6sh35AJYj8YRYUzTAi 6eVQ5eVpSvUTkeDTbw69ZX1pS; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:44186 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1huh0q-000PkR-J1; Mon, 05 Aug 2019 12:43:12 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue References: <20190805124152.26127-1-alan.hayward@arm.com> Date: Mon, 05 Aug 2019 17:43:00 -0000 In-Reply-To: <20190805124152.26127-1-alan.hayward@arm.com> (Alan Hayward's message of "Mon, 5 Aug 2019 12:41:55 +0000") Message-ID: <8736ifcxu8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00119.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> When saving registers to the stack at the start of a function, not all state Alan> needs to be saved. For example, only the first 64bits of float registers need Alan> saving. However, a program may choose to store extra state if it wishes, Alan> there is nothing preventing it doing so. Alan> The aarch64_analyze_prologue will error if it detects extra state being Alan> stored. Relex this restriction. I don't know anything about AArch64, so I can't really comment on the content of the patch, but I did happen to see a nit: Alan> stack.store (pv_add_constant (regs[rn], Alan> inst.operands[1].addr.offset.imm), Alan> - is64 ? 8 : 4, regs[rt]); Alan> + size, regs[rt]); ...this addition looked mis-indented to me. Tom