From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68986 invoked by alias); 25 Nov 2019 22:06:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68978 invoked by uid 89); 25 Nov 2019 22:06:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=person X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.50.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 22:06:23 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 1A9A2400C8012 for ; Mon, 25 Nov 2019 14:56:47 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZMUviMXIH3Qi0ZMUwide1Z; Mon, 25 Nov 2019 16:06:22 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k/ZavTVF/2ea+9MwErERabVGMPM6OjxKUGJefCkJgfs=; b=j2zuLD1L8yH7fFXVh4kv7K8inj TIpumTbDQ03Mz9rUmhRDm9X1VDtBzazAj2bgBREOnvtV4IE+dBk0UzrZEBlRVof5lYYMWTJPegAdc s538Kd8Fwdxm09md/rFEojtJg; Received: from 97-118-104-188.hlrn.qwest.net ([97.118.104.188]:51260 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iZMUv-0017uV-Oz; Mon, 25 Nov 2019 15:06:21 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 15/15] Enable -Wmissing-declarations diagnostic References: <20191125052655.22696-1-simon.marchi@efficios.com> <20191125052655.22696-16-simon.marchi@efficios.com> Date: Mon, 25 Nov 2019 22:06:00 -0000 In-Reply-To: <20191125052655.22696-16-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 25 Nov 2019 00:26:55 -0500") Message-ID: <8736eb8vc2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-11/txt/msg00848.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Now that most warnings of this kind are fixed, we can enable Simon> -Wmissing-declarations. I say "most", because it is likely that there Simon> are some more in some configurations I am not able to build, but they Simon> should be pretty easy to fix. Simon> gdb/ChangeLog: Simon> * warning.m4: Add -Wmissing-declarations to build_warnings. Simon> * configure: Re-generate. gdbserver uses warning.m4, so you have to also rebuild configure there and fix up any issues -- otherwise, the next person to rebuild gdbserver/configure will be surprised. Tom