From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114633 invoked by alias); 12 Feb 2020 00:20:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114612 invoked by uid 89); 12 Feb 2020 00:20:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 00:20:22 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 9F6B4C0DD for ; Tue, 11 Feb 2020 18:20:21 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1flNjMPXSXVkQ1flNjkiSw; Tue, 11 Feb 2020 18:20:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HLqA7/oHggBIDqx2khpzP4F53yA6iXjcMvwpwfck4Ww=; b=lZaN/GXbRHheZ3ZRt2nSZpwsrf OnRVFX3+6W6oS7i8yP35TxrQF4qKDDWzk45+oWlhJJxfJtlNwq93hdj6cu6VrchQ+PFczKo7EsgiX h81Xn2+A2sXzrJ1fYN+RHz9p/; Received: from 50-194-130-62-static.hfc.comcastbusiness.net ([50.194.130.62]:36018 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j1flN-001Hri-Cz; Tue, 11 Feb 2020 17:20:21 -0700 From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] Store the comp_unit instead of the FDE table References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-5-tom@tromey.com> <79011422-82b0-6f2c-4772-c23dfd46c87e@linaro.org> Date: Wed, 12 Feb 2020 00:20:00 -0000 In-Reply-To: <79011422-82b0-6f2c-4772-c23dfd46c87e@linaro.org> (Luis Machado's message of "Tue, 11 Feb 2020 07:31:59 -0300") Message-ID: <8736bgd5bv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00419.txt.bz2 >>>>> "Luis" == Luis Machado writes: >> + comp_unit *unit = dwarf2_frame_objfile_data.get (objfile); >> + if (unit == NULL) >> { Luis> NULL -> nullptr. >> dwarf2_build_frame_info (objfile); >> - fde_table = dwarf2_frame_objfile_data.get (objfile); >> + unit = dwarf2_frame_objfile_data.get (objfile); >> } >> - gdb_assert (fde_table != NULL); >> + gdb_assert (unit != NULL); Luis> NULL -> nullptr I made these changes. Tom