From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56977 invoked by alias); 12 Feb 2020 22:36:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56967 invoked by uid 89); 12 Feb 2020 22:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.124.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 22:36:12 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 8238F414FE1AD for ; Wed, 12 Feb 2020 15:50:14 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 20c6jlPu5XVkQ20c7j9W18; Wed, 12 Feb 2020 16:36:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WV2xmwrZm6SbnWyhe5IGcLA+WC76t/1wwvJ+kFzTr8o=; b=d1Ljawq2L3mGeaHFT5hE+It7jD eVcjBvYDwRon/iOf0RhDy2iRQCKz39ZiJZH7slu0MpEGeVMQKv91yo+97+jo9p8af3hfI4gi3cGCM KVp2T1t455Wl5yJbF9EQYqdrH; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56214 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j20c6-001d2W-PD; Wed, 12 Feb 2020 15:36:10 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] Change fde table to a vector References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-4-tom@tromey.com> Date: Wed, 12 Feb 2020 22:36:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 11 Feb 2020 22:28:46 -0500") Message-ID: <8736bfsaau.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00468.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> As a further change, I think we could consider make this a vector Simon> of objects, rather than a vector of pointers. I think I'd rather leave this for a future change. It makes the patch a lot less obvious, to me anyway. find_fde returns a pointer -- but is that safe? I think so, but I am not 100% certain; but with the current code it definitely is. >> +const struct objfile_key dwarf2_frame_objfile_data; Simon> Can you make this static, while at it? I did this. >> + if (!fde_table.empty ()) Simon> If you want to simplify the code even further, you could get rid Simon> of this check, since the code below should cope well with an Simon> empty vector. Thanks, I did this too. >> + fde_table2->shrink_to_fit (); Simon> That shrink_to_fit appears to be pointless, as fde_table2 is Simon> created empty and we only push_back. Maybe you meant to create Simon> it with an initial size? IIUC push_back normally uses some resize factor; the shrink_to_fit is a request to discard any excess memory allocated this way. FWIW another thing that could be done in this code is to use the remove_if to remove elements in-place from fde_table. This is another thing I'd rather do separately. Tom