From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Don't set initial language using previous language
Date: Fri, 28 Feb 2020 15:04:00 -0000 [thread overview]
Message-ID: <8736aun46o.fsf@tromey.com> (raw)
In-Reply-To: <20200228063315.GA16995@delia> (Tom de Vries's message of "Fri, 28 Feb 2020 07:33:16 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> It seems like a bad idea to have the previous language play a role
Tom> in determining the executable language.
Does it make a difference in practice?
Tom> Fix this by using lookup_symbol_in_language in set_initial_language with the
Tom> default language c as argument.
Tom> Tested on x86_64-linux.
Tom> OK for trunk?
Yes, it seems fine to me. Thank you.
Tom
next prev parent reply other threads:[~2020-02-28 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 6:33 Tom de Vries
2020-02-28 15:04 ` Tom Tromey [this message]
2020-02-28 15:19 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736aun46o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox