Re: [PATCH 19/22] Change two more functions to be methods on die_info

Tom Tromey
2020-03-26T02:17:44Z

>>>>> "Christian" == Christian Biesinger <cbiesinger@google.com> writes:

>> + attr = attr (DW_AT_addr_base);

Christian> I get that you want to avoid making code changes while moving code but
Christian> I would really suggest merging these two lines at least (similar in
Christian> the next function)

This line doesn't even compile actually.
I must have only built this after writing the next patch? Ugh.

Anyway I changed it as you suggest and used this->attr, which I normally
wouldn't do, but thought was ok since this patch is just a transition.

Tom