From: Tom Tromey <tom@tromey.com>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Don't compare types of enum fields
Date: Fri, 18 Dec 2020 13:30:10 -0700 [thread overview]
Message-ID: <873602n9gt.fsf@tromey.com> (raw)
In-Reply-To: <20201217192912.1981-1-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Thu, 17 Dec 2020 20:29:12 +0100")
>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
Hannes> PR exp/27070
Hannes> * gdb.base/pr27070-a.c: New test.
Hannes> * gdb.base/pr27070-b.c: New test.
Hannes> * gdb.base/pr27070.exp: New file.
Hannes> * gdb.base/pr27070.h: New test.
We normally don't name tests after PRs.
I don't recall why this is, and I didn't see it in the test-writing guidelines.
But anyway, I recommend picking a descriptive name instead.
Tom
next prev parent reply other threads:[~2020-12-18 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201217192912.1981-1-ssbssa.ref@yahoo.de>
2020-12-17 19:29 ` Hannes Domani via Gdb-patches
2020-12-18 20:30 ` Tom Tromey [this message]
2020-12-18 21:27 ` Simon Marchi via Gdb-patches
2020-12-18 22:00 ` Hannes Domani via Gdb-patches
2020-12-18 22:14 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873602n9gt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox