From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id H/DZEk0lXmAhSgAAWB0awg (envelope-from ) for ; Fri, 26 Mar 2021 14:17:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 3AE3E1EF7C; Fri, 26 Mar 2021 14:17:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9AB441E789 for ; Fri, 26 Mar 2021 14:17:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 33F063857C44; Fri, 26 Mar 2021 18:17:48 +0000 (GMT) Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.59.4]) by sourceware.org (Postfix) with ESMTPS id 3EE9C3860C32 for ; Fri, 26 Mar 2021 18:17:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3EE9C3860C32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 3AC36400C5939 for ; Fri, 26 Mar 2021 13:08:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Pr1klV09Vb8LyPr1klplYP; Fri, 26 Mar 2021 13:17:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1uC2qqYC4sm6B4AEVsUV6UW94lEKd0x+jgGUVRh8rFc=; b=enia7LJ//g1hyEmvS8g5fTpx+x jCgEA89fDk7LjwA0VHNjS/DpZLgorHxiETHWnI21tgl8t0zzrFddxVPWcZ5Bkd21oJtOVdmU+QS8+ WXsaKVugLp+6RiB8JfriYE5hP; Received: from 71-211-130-165.hlrn.qwest.net ([71.211.130.165]:43734 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lPr1j-003PMn-R6; Fri, 26 Mar 2021 12:17:43 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH 1/2] Allow expand_symtabs_matching to examine imported psymtabs References: <20210324201510.23655-1-tom@tromey.com> <20210324201510.23655-2-tom@tromey.com> <514da557-94e9-23c3-df1a-59ae42e32399@polymtl.ca> X-Attribution: Tom Date: Fri, 26 Mar 2021 12:17:43 -0600 In-Reply-To: <514da557-94e9-23c3-df1a-59ae42e32399@polymtl.ca> (Simon Marchi's message of "Thu, 25 Mar 2021 15:29:39 -0400") Message-ID: <8735whg4oo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.165 X-Source-L: No X-Exim-ID: 1lPr1j-003PMn-R6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-165.hlrn.qwest.net (localhost.localdomain) [71.211.130.165]:43734 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: >> - /* We skip shared psymtabs because file-matching doesn't apply >> - to them; but we search them later in the loop. */ >> - if (ps->user != NULL) >> - continue; >> - Simon> I'm not against this change, but I don't understand it. It seems Simon> logical to me to skip shared psymtabs, because we'll reach them through Simon> some other psymtabs that include them. So, both versions seem correct, Simon> but maybe knowing why it's convenient to you would help. If the shared psymtab has a file name, then that file name will not be checked by the file matcher. This doesn't matter directly now because file matching is often done via a different method, that does check these. However, with my proposed series to remove the redundant methods, this issue is exposed. Tom