From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Implement putstr and putstrn in ui_file
Date: Wed, 05 Jan 2022 11:00:25 -0700 [thread overview]
Message-ID: <8735m2rrk6.fsf@tromey.com> (raw)
In-Reply-To: <20220105173912.GA828155@redhat.com> (Andrew Burgess's message of "Wed, 5 Jan 2022 17:39:12 +0000")
>> -/* Like fputstrn_filtered, but don't escape characters, except nul.
>> +/* Print a string, but don't escape characters, except nul.
>> Also like fputs_filtered, but a length is specified. */
Andrew> Given you're changing this comment anyway, please could you get rid of
Andrew> the "Also like fputs_filtered...", we can just say something like:
Andrew> /* Print a string S, length SIZE, but don't escape characters,
Andrew> except nul. */
Andrew> Then, everything is self contained.
Andrew> Otherwise, this version looks great.
Thanks. I made that change and I'm checking it in.
Tom
prev parent reply other threads:[~2022-01-05 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 18:01 Tom Tromey
2021-12-31 19:27 ` Lancelot SIX via Gdb-patches
2022-01-02 23:46 ` Tom Tromey
2022-01-05 17:39 ` Andrew Burgess via Gdb-patches
2022-01-05 18:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735m2rrk6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox