From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CJxYEpike2KMoAUAWB0awg (envelope-from ) for ; Wed, 11 May 2022 07:57:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 46F481E21F; Wed, 11 May 2022 07:57:12 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=EeAJBXmU; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 11C4C1E00D for ; Wed, 11 May 2022 07:57:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B67503856256 for ; Wed, 11 May 2022 11:57:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B67503856256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652270230; bh=GjYUCYFJU/XHVLBtyxzCfP0Ti+5j2WCo4bVij/nUpXs=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EeAJBXmULsz3In5+Qc6eVz9Gy2635uYO6xy9HiPMMLDvzub1fBW277xiWiOBd2sgt Hwk2N8t0RXNPErtf0ASOPQeEA6OfsBrpxLibtvFhQSEvlq63ZAlEbx2xu79yXGtez5 7a9a+XqO2Mo5c3nEIG4wMMovrKWuavzy01HMN8hI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 664C53858CDA for ; Wed, 11 May 2022 11:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 664C53858CDA Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-439-14FhtmvDPa-X_RXuvEGMZA-1; Wed, 11 May 2022 07:56:50 -0400 X-MC-Unique: 14FhtmvDPa-X_RXuvEGMZA-1 Received: by mail-wr1-f70.google.com with SMTP id t17-20020adfa2d1000000b0020ac519c222so761128wra.4 for ; Wed, 11 May 2022 04:56:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=GjYUCYFJU/XHVLBtyxzCfP0Ti+5j2WCo4bVij/nUpXs=; b=jfNKcxChCgyZQl3ko2zJMC5Ucw4VhmWGi/PKuT8L1uf5MxOLlL1EcIXrZWLj9IaKS7 7/M78S/nDEoTaKP7PT908iw+cVoW3DYjF8WRuxHChx6TsN0rbUsCQqzzfEuXGW2CQ5Gr amMc8g8+U5jnPeXaf+CfHg1AsLp2xoTYNRycAYRG9W3g5B9ncALTzySNQ16/BQPjWXXa 0yZF2SF0Gjr8AUQr+ZXFQhhjE9MVM9LpS7Ap/Ye3JQzhsthOeCY0SB3+jvRQPtOe+op7 f4WkryAvJr6/1UroJuMURWUj5+U/2bexZQaFFqu+NMhmj7XxGYpX1+dCqjHeWm0rcmHU /koA== X-Gm-Message-State: AOAM533ntn1L1uheSonUrN4huA/DDKqhfu30V4FWeJBrC+YJELc7xYTO A9KieCSOoRRV36sNmNWeLO4ND7LgTdHEbR6EfHhRuN60VH+2vx4OPIG0vZnOiFaI17kOHO6kgq+ 7sLguxxD8izOc09K7r1y2ag== X-Received: by 2002:a5d:5984:0:b0:20c:7de2:5416 with SMTP id n4-20020a5d5984000000b0020c7de25416mr22294563wri.30.1652270208731; Wed, 11 May 2022 04:56:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSx+CvCSFhGGcxnDwem6z7H0tPCJwJxdKY/K1awjwwL5he2THNBJJddGHqVRqctMRvIZxhpA== X-Received: by 2002:a5d:5984:0:b0:20c:7de2:5416 with SMTP id n4-20020a5d5984000000b0020c7de25416mr22294552wri.30.1652270208506; Wed, 11 May 2022 04:56:48 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id y19-20020a1c4b13000000b003945237fea1sm2018599wma.0.2022.05.11.04.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 04:56:47 -0700 (PDT) To: Nils-Christian Kempke , gdb-patches@sourceware.org Subject: Re: [PATCH 11/18] testsuite, fortran: Add '-debug-parameters all' when compiling with ifx In-Reply-To: <20220510142437.1397399-12-nils-christian.kempke@intel.com> References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-12-nils-christian.kempke@intel.com> Date: Wed, 11 May 2022 12:56:46 +0100 Message-ID: <8735hgl1tt.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: JiniSusan.George@amd.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Nils-Christian Kempke writes: > In order for ifx to emit all debug entries, even for unused parameters > in modules we have to define the '-debug-parameters all' flag. > > This commit adds it to the ifx-* specific flags in gdb.exp. > --- > gdb/testsuite/lib/gdb.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index b8e61d846d..e799312c12 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4439,6 +4439,8 @@ proc gdb_compile {source dest type options} { > # Place (and look for) Fortran `.mod` files in the output > # directory for this specific test. For Intel compilers the -J > # option is not supported so instead use the -module flag. > + # Additionally, ifx needs the -debug-parameters all flag set to emit I think you should place quotes around the "-debug-parameters all" to indicate that the "all" is part of the flag, or, just drop the "all", we can see what -debug-parameters is set too by looking below. This is fine with that change. Thanks, Andrew > + # debug info for all parameters in modules. > if { $getting_compiler_info == 0 && [lsearch -exact $options f90] != -1 } { > # Fortran compile. > set mod_path [standard_output_file ""] > @@ -4447,6 +4449,9 @@ proc gdb_compile {source dest type options} { > } elseif { [test_compiler_info {ifort-*} f90] > || [test_compiler_info {ifx-*} f90] } { > lappend new_options "additional_flags=-module ${mod_path}" > + if { [test_compiler_info {ifx-*} f90] } { > + lappend new_options "additional_flags=-debug-parameters all" > + } > } > } > > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928