From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FfDANzqhvmhLrDYAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 05:26:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WMpbX9fI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B10511E0BA; Mon, 08 Sep 2025 05:26:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A91501E04C for ; Mon, 08 Sep 2025 05:26:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 175E53858D20 for ; Mon, 8 Sep 2025 09:26:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 175E53858D20 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WMpbX9fI Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 955323858C42 for ; Mon, 8 Sep 2025 09:25:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 955323858C42 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 955323858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757323524; cv=none; b=XHL2GbThj8+OoQkXY6yYb6ZX6Jl+GpW/wavKXYHF16bTX/5Szp52byCAuhyj0iHTs9M6lPXJXTvH9+rZw2vlQodK9bmY9XL9ZKlcP/XNS3a3a/AhVR1HgT2wr7D6fX0q16lEp4pn39G5wg2kX5JRklclqplhOndP4yjpd95ij9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757323524; c=relaxed/simple; bh=13Hz7NyWOf0AHO77R6kumrRyKCRvMQ3OAqMS5ygcAiI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=biVec0IKf4giKYV7U94fLvnAsrCL1Ryo7x4TTAp9VdLcQ9rvf5FuglHAzAV6CmJcZNwNad5XmeF1daHaYrZce0hKzGEQJtB65muGTKCLhKnqudoAUeTyyi09nWDF0h/Wx4UHw9Di8C823jVccp0tJA48Ut7fGC98zbSNyz3Ps+M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 955323858C42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757323524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rSrNO8+vH11zgSX/SV/imLuyx2urk3kK6WcNuvrJeVA=; b=WMpbX9fICuRXehI7EtYLXfbSP9x9yytmOibwXnnfO+JUwT4iLF9OZzAvZKmW7zMl4X0xiL BFdI4VNpIjkxNHl083e88PDsVPXJ4dhA4A0v74NegqvVrjtHjWtedjW2RRR219ujMU01Iw 6wizgg4pRQxbcBhJ0hdiZ3U0MVMJIss= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-PC9ShH22N0Ouv0iTvmZfug-1; Mon, 08 Sep 2025 05:25:20 -0400 X-MC-Unique: PC9ShH22N0Ouv0iTvmZfug-1 X-Mimecast-MFC-AGG-ID: PC9ShH22N0Ouv0iTvmZfug_1757323520 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45de07b831dso8439515e9.1 for ; Mon, 08 Sep 2025 02:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757323519; x=1757928319; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rSrNO8+vH11zgSX/SV/imLuyx2urk3kK6WcNuvrJeVA=; b=E8MdyQz5RXQWttb55/f6tW/jxDfOMEBjaSm8IJwO1AiI1SE6Essh3Sy2HN+IbG8iPV mHdc21DP429L/2IgAAhgV8oRE4go+MLnlr1gfP7OE5oPGlaebJL8MdDJOq1fiLmwaFiZ eNE9gSS0ewDl2JcsLGa+PIwi1v6VYde9/Q6KExTg/1noj6UM7EV3snjhRJFMLJVOYAbD ddseVU3yh1hWyv+23BxJE209u3wpl5twlwbOEfQIZjO/TJxeAEJPXIpyayHzXZGZfcgi oCfUxRU3APiisG5TiiSL4+mCMG2CtM23bxHH65vr2poPohDDQlGtxmLeAjN2BiV6daP4 6Ncg== X-Gm-Message-State: AOJu0Yw4TlZrKqxxQZ5CNNYw5trXuC2Q6mK43vgu2NtOaufwCWmD6LF9 dZCgjqRvQWMsqnBzKFtepgI1bKXaWBVCxCFXCkd9npv6IFtp8kq1ZZ+dUv7f3yf0O8H+RllC6Re wbIwO3pFqoSIzDsyZeopXRSxDFg+Fif6BpUZeZvhdj3DvIwFUPVdl+Lowgsq8O/SECUhw0fq61G YNkcp5J4xpZlUkRvzhcM8jdfji2zmzfU2z2HpKPWVfN/AH3yU= X-Gm-Gg: ASbGncuAQKqiXPyBkwmeSFrYfj8OVgk0OhM0kCotia0uIp4wIUnAkGITZcZ0AUAvWll LRgrbkK1gXyp2QIimUz84YdHELL1fJ7JZcRrR9omp7V9cwo2G1fhLKHprJ0lhRUOJEbMrP9MGNl cwNM8+ob3PL0iIT0k1GSFZjEInStm0k9gz3wxXBbR0Fvb7+nBWq/otWAWnirbMoLr9If51F4Dka 9m75WkaLC0y5E8nfb1w9BndDnWdIoK37rJWmgljV3LbBdQInS+HnCqX7yL2/ksu4Cd4djDd0FjM CPWc4IObiavD6ksSBXfSiPWQb13/1iniCN9rFNE1f7+P6ki38QnlvAtjKRdfBtG2 X-Received: by 2002:a05:600c:1c9f:b0:45b:75f0:2d66 with SMTP id 5b1f17b1804b1-45ddde814ccmr63967795e9.4.1757323519312; Mon, 08 Sep 2025 02:25:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErH5+SdqREBu58Q4fjbcYVBs8uGI0qvhGb44CPuqtR1EWM61GSMNKrT0opV/wvWNb5QJcAbw== X-Received: by 2002:a05:600c:1c9f:b0:45b:75f0:2d66 with SMTP id 5b1f17b1804b1-45ddde814ccmr63967395e9.4.1757323518809; Mon, 08 Sep 2025 02:25:18 -0700 (PDT) Received: from localhost (92.40.185.174.threembb.co.uk. [92.40.185.174]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45dda4f2a0dsm129769605e9.2.2025.09.08.02.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 02:25:18 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: small fix for amd64-extended-prologue-analysis.exp Date: Mon, 8 Sep 2025 10:25:14 +0100 Message-ID: <8735dae5139ecf2d3a79508371c9c861fde12c44.1757323506.git.aburgess@redhat.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mcuo5ibAeu2eSWw49GYKudq9pTf6oHxeK6UkhiZHzXs_1757323520 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed I was sometimes getting this failure: FAIL: gdb.arch/amd64-extended-prologue-analysis.exp: offset \ initialization: ASM source: gdb_breakpoint: set breakpoint \ at *0x0000000000401151 The problem was introduced in commit: commit f9aa48dc545ef511e19f4dfab88a196b820fd2da Date: Thu Aug 28 11:50:13 2025 +0000 gdb, amd64: extend the amd64 prologue analyzer to skip register pushes A gdb_test_multiple exits early when processing the results of a 'disassemble' command, without waiting for the prompt to be seen. This can leave unhandled output in expect's input buffer, which will then throw off the next test. Update the gdb_test_multiple to wait for the prompt before declaring the test passed. After this I'm no longer seeing the above failure. There should be no change in what is tested after this commit. --- .../gdb.arch/amd64-extended-prologue-analysis.exp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp b/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp index b2fcbe66034..356afc7e668 100644 --- a/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp +++ b/gdb/testsuite/gdb.arch/amd64-extended-prologue-analysis.exp @@ -59,9 +59,13 @@ proc offset_test_run {} { set addr_past_prologue "null" gdb_test_multiple "disassemble" "Disassemble foo" -lbl { - -re "($::hex) <\\+($::decimal)>:\\s*mov.*" { + -re "\r\n\\s*($::hex) <\\+($::decimal)>:\\s*mov.*(?=\r\n)" { set addr_past_prologue $expect_out(1,string) - pass $gdb_test_name + exp_continue + } + + -re -wrap "" { + gdb_assert { $addr_past_prologue ne "null" } $gdb_test_name } } base-commit: 5d0ac9ee8fd007e90ba3fef3b95fd756cc191401 -- 2.47.1