From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x4t4K9BF8WaVajQAWB0awg (envelope-from ) for ; Mon, 23 Sep 2024 06:41:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JPFAoeCL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 90C7E1E353; Mon, 23 Sep 2024 06:41:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BEA691E05C for ; Mon, 23 Sep 2024 06:41:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 126E93858C41 for ; Mon, 23 Sep 2024 10:41:19 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AA2083858D20 for ; Mon, 23 Sep 2024 10:40:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA2083858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA2083858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727088058; cv=none; b=lgBbC7odvV0OxeKyY8hp3cqP95K+pp9Ei2kQkaEnbFtzjYYuHkXS2zZUJ6r2VDzEjY9BGIdh6N1DFLyg2/ZwlrkHAugueeEwzoyycWe04sr1HnlFnWjdRl722HhOVfy+F5sXoA1XCzpj8G61FDIcJgBx36QG3vycBPQ3q5wC6C4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727088058; c=relaxed/simple; bh=KvY/nU/kQSzeoYs4DgL86oCTlLZo1OJhpkh7tQxfFxQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OQGbPcvC+wGZyO+EawBVT8AqkPfzwBNSjBfQp1DYS8gYPdJLVFkM42hcqvZOxcOGVKSM+qseirkLKyu1ni59AfY/UvJYS3XHV7bX7Jm1KeqJmxE9oZby+VbtQl5pSm8mZ1UQKuE+uZInPQ/eIwF+CXAP2Mzf+r0oFHxqezNgmHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727088056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CLaeE6OxqTCVs1eSgx6Rp3bA7JOEFvdsnjG2YaBFOzQ=; b=JPFAoeCLvsS7n+NTxSfeSy+KjDFkXdBbdGpp9HG6SUOED97JAeNnXxxujl1jfMsksox2GU 0ES/6HP+kCDIoiyLQxYe0WfSJZ9BzNZjqbNOIZT49YNakEFz6DTXFDgrp6mjg+QBrRCtlr rnLVEEbpin1/9AsBwWVJtetBDhN4E8g= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-4GYosD-CP36DyjKAjQ6lvQ-1; Mon, 23 Sep 2024 06:40:55 -0400 X-MC-Unique: 4GYosD-CP36DyjKAjQ6lvQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a8d1095442cso303380466b.3 for ; Mon, 23 Sep 2024 03:40:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727088051; x=1727692851; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CLaeE6OxqTCVs1eSgx6Rp3bA7JOEFvdsnjG2YaBFOzQ=; b=lt/QsXefajCyL8ZY6jG/NEGRfW+oTbIl+W8aAi8pFnffewn6aXlgWacB9oLGVThglA avInVYZkICrCQijwnbpQaSdpzz3rn3tiq48vDDuBkYvzCWHLIAJ4J19WsQR1MbojqAGz se+OAHKCcf3KeklA//NnKU3+23MQuhy05+ozT3Ec10ylq8dx8Gg9HJ1VWyckIcVJnWLW Li8Nbrp9ISfv2Z/eTZl+gbiF00JJockAHy0T38TUv2mYxSw6rSFyWUTg3m3nYUGnTGpw wyhCXNqCbgUGtoPS1cnBBsGuIV1ArIprahslyYkc2/Wrdm4088wsuwBhYg00Y+UpLbpG d7JA== X-Forwarded-Encrypted: i=1; AJvYcCXrocPrAZcAd3B9G/v4XspytXCJVK+7m0WxIqkw0lD3jfEg+RThJed7cJgRKq7+guPq6+paPLx1Pz/rGQ==@sourceware.org X-Gm-Message-State: AOJu0YxuNkrnumRrA/fx6OxZ6TmgloH3a+fZ/Ujz5UvW9bui6wthBAen kDcS9oR1g4aAQlBAkXwyB8mA0rMGMkhtHgHZhZWHADAzuNOZc8CGqPafSLlWxI/zLV9xCRgO+u+ 894rawWexq4NajNK2oekLTXlYjWWw9QTOH/YHAqxRl04RWWKjDg/jbEfmu+o= X-Received: by 2002:a17:907:f156:b0:a86:6cb1:4d49 with SMTP id a640c23a62f3a-a90d4fdfe59mr1132865566b.13.1727088050936; Mon, 23 Sep 2024 03:40:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmSaF6/zbS3Ko8FbPDWFwqA6RZ1un27DyJAQ3uxysIOQ9MZzZbdxKD+FKWmBPQysNpwZ15fQ== X-Received: by 2002:a17:907:f156:b0:a86:6cb1:4d49 with SMTP id a640c23a62f3a-a90d4fdfe59mr1132863466b.13.1727088050523; Mon, 23 Sep 2024 03:40:50 -0700 (PDT) Received: from localhost (178.126.90.146.dyn.plus.net. [146.90.126.178]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612e4ba5sm1192403766b.182.2024.09.23.03.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 03:40:50 -0700 (PDT) From: Andrew Burgess To: "Aktemur, Tankut Baris" , Guinevere Larsen , "gdb-patches@sourceware.org" Cc: Keith Seitz , Tom Tromey Subject: RE: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining In-Reply-To: References: <20240919124204.1465834-1-blarsen@redhat.com> <1940030f-122d-4656-a293-44e5b5a98c92@redhat.com> <87setunoiq.fsf@tromey.com> <2e594120-cf6a-4c4b-9413-5b0cdb0456f4@redhat.com> Date: Mon, 23 Sep 2024 11:40:49 +0100 Message-ID: <8734lq1wlq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Aktemur, Tankut Baris" writes: > On Friday, September 20, 2024 9:11 PM, Guinevere Larsen wrote: >> On 9/20/24 3:55 PM, Tom Tromey wrote: >> >>>>>> "Keith" == Keith Seitz writes: >> > Keith> On 9/20/24 9:20 AM, Guinevere Larsen wrote: >> >>> I've given some more thought and I think a couple of comments could >> >>> help anyway. Here's my suggestion, thought? >> > Keith> I am pleased to have an explanation there. Thank you! >> > >> > FWIW I read through this and it all seems fine to me as well. >> > Thanks for your review Keith. >> > >> > Approved-By: Tom Tromey >> > >> > Tom >> > >> Thanks, pushed! > > I'm sorry to chime in late. Just two comments, in case you'd want to consider > further edits. > >>> + {debug c++}] == -1 } { > > It may make sense to rename the file extension to .cc. Also, maybe if the test is now just C++, wouldn't moving it to gdb.cp/ make sense? Thanks, Andrew > >>> + int res = foo ('1'); /* Single-location breakpoint here. */ > > For a quick reader, changing the argument to 'A' may make it more > apparent that this is a char. > > Thanks > -Baris > > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928