From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4G8sJHRhN2jgOTgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:18:12 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FcdvxK7M; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 90B071E11C; Wed, 28 May 2025 15:18:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 331A01E102 for ; Wed, 28 May 2025 15:18:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE15D38560A3 for ; Wed, 28 May 2025 19:18:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE15D38560A3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FcdvxK7M Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D67F23856DFA for ; Wed, 28 May 2025 19:17:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D67F23856DFA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D67F23856DFA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748459859; cv=none; b=kr8ZQfh9YLlRPx49VzZWUIS7k9xjuHvHf/9YlCyhjg+GLkJxOFhSIg/NPsIdF59sdiO7nNjckHkCxXifpSWOx/TeYM5hoafUAjuu9g3yFKtemHVDwy7RXTJA+flB/NwKBHy/ZCNiwGF9/VNYDRQqmb7XEIUaTP3OY7uxIbJZpUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748459859; c=relaxed/simple; bh=gZiPob5FvcnS5ZWw/pUKdT9yGEeWa0KDWT1904amwT0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iyR3yytdqoDE04XRjKgG5E5c0S+u4ABErEbidV3NKYrAU1Lb/3pkiWfGQX+lanUYpjULJAfFZuz1fsg48p6JFw3/yLOY/rntGsWQe2+bCUFPjHYIItFTT4NNyxFsfBB582NmwGALC7H5Jl7cFfNO9S1IBOduh7kJZIWScOec5zk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D67F23856DFA Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id KHopusg4TAfjwKMHSun3um; Wed, 28 May 2025 19:17:38 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMHRuxNuE3IrfKMHRuA9fT; Wed, 28 May 2025 19:17:37 +0000 X-Authority-Analysis: v=2.4 cv=PL4J++qC c=1 sm=1 tr=0 ts=68376151 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=NEAV23lmAAAA:8 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=qn6gEd8FKsIZ5dN1HXgA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6I5SrElc2VkYDCVVMS6fczaz7z0oOja55qZsg7QMW3o=; b=FcdvxK7MlRocgUrTJH7/n21Pph +6ey4jTxpHKEVeNF0Bf9oPgQ6s6Y0yvKTduWks74fxp9pxd+2SO24dm9XDCauZzw9cDhjFV69fyqU VPZwydJILdDHl7Ez398jqftzz; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:42172 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMHQ-00000002XBX-2mDa; Wed, 28 May 2025 13:17:36 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 15/47] Windows gdb+gdbserver: Move suspending thread to when returning event In-Reply-To: <20250519132308.3553663-16-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:36 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-16-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:17:34 -0600 Message-ID: <8734coh7e9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMHQ-00000002XBX-2mDa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:42172 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHyD2U2YWbPLYtgN7x7Xaeo4zrIXcNgLRBrtMjrca+HWZdnf2r7pNVIKdbkhRFt7ioodPXJCld2Pb0UWKoWkiDrhrVMMGueYrGzPZ612DWkEDqlkRnf2 pwmu1qFEfTSI197/0u9U7HWH6k6bRv86shTYTXMeXnO+rKcMniKf9RXX8TVEmh/H0wF9y7Zwkec6afmbzjkS99O5257VoE7yaJg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> The current code suspends a thread just before calling Pedro> GetThreadContext. You can only call GetThreadContext if the thread is Pedro> suspended. But, after WaitForDebugEvent, all threads are implicitly Pedro> suspended. So I don't think we even needed to call SuspendThread Pedro> explictly at all before our GetThreadContext calls. I long suspected this code was wrong but never tried to do anything about it. Pedro> However, suspending threads when we're about to present a stop to gdb Pedro> simplifies adding non-stop support later. This way, the windows Pedro> SuspendThread state corresponds to whether a thread is suspended or Pedro> resumed from the core's perspective. Curiously, I noticed that Wine's Pedro> winedbg does something similar: Pedro> https://github.com/wine-mirror/wine/blob/234943344f7495d1e072338f0e06fa2d5cbf0aa1/programs/winedbg/gdbproxy.c#L651 Pedro> This makes it much easier to reason about a thread's suspend state, Pedro> and simplifies adding non-stop mode later on. Thanks. Approved-By: Tom Tromey Tom