From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97211 invoked by alias); 9 Oct 2016 19:18:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97198 invoked by uid 89); 9 Oct 2016 19:18:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Oct 2016 19:17:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4D0F624D8; Sun, 9 Oct 2016 19:17:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u99JHs7S027581; Sun, 9 Oct 2016 15:17:55 -0400 Subject: Re: [RFA 21/22] Convert DWARF expr functions to methods To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-22-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <87348bb5-0784-24f4-f5ad-6e9e0acff740@redhat.com> Date: Sun, 09 Oct 2016 19:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-22-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00209.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > This converts various DWARF expr functions to be members on > dwarf_expr_context, then fixes up the various users. This results in > somewhat less wordy code and sets the stage for the next patch. > > 2016-09-26 Tom Tromey > > * dwarf2loc.c (per_cu_dwarf_call) > (dwarf_expr_push_dwarf_reg_entry_value) > (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval) > (needs_dwarf_reg_entry_value) > (dwarf2_loc_desc_get_symbol_read_needs): Update. > * dwarf2expr.h (dwarf_expr_context) fetch_address, fetch_in_stack_memory, address_type, grow_stack, > push, stack_empty_p, add_piece, get_base_type, execute_stack_op, > pop>: New method declarations. > (dwarf_expr_push_address, dwarf_expr_eval, dwarf_expr_fetch) > (dwarf_expr_fetch_address, dwarf_expr_fetch_in_stack_memory): > Don't declare. > * dwarf2expr.c (address_type, grow_stack, push, push_address) > (pop, fetch, fetch_address, fetch_in_stack_memory) > (stack_empty_p, add_piece, eval, get_base_type) > (execute_stack_op): Rename. Turn into methods. > * dwarf2-frame.c (execute_stack_op): Update. LGTM. Thanks, Pedro Alves