From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Free multidicts from blockvector
Date: Thu, 23 Oct 2025 12:52:12 -0600 [thread overview]
Message-ID: <873479bgdf.fsf@tromey.com> (raw)
In-Reply-To: <c81dfe5a-c004-4ea7-be9a-7ce07d125d5c@simark.ca> (Simon Marchi's message of "Thu, 23 Oct 2025 14:31:45 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + for (struct block *bl : m_blocks)
>> + mdict_free (bl->multidict ());
>> +}
Simon> Ideally it would be struct block's just to call that. You could add a
Simon> destructor to struct block and call it explicitly here. It would be the
Simon> same result, but would be more correct encapsulation-wise. But I guess
Simon> this is fine too for the time being.
Yeah. I have kind of an aversion to explicit destructor calls.
Though maybe not for any good reason.
Simon> Since there is a user-defined destructor, I would add a
Simon> DISABLE_COPY_AND_ASSIGN. Otherwise, LGTM.
I did this.
Tom
next prev parent reply other threads:[~2025-10-23 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 17:17 [PATCH 0/2] Fix memory leak with .debug_types Tom Tromey
2025-10-23 17:17 ` [PATCH 1/2] Two bug fixes in mdict_free Tom Tromey
2025-10-23 18:26 ` Simon Marchi
2025-10-23 18:32 ` Simon Marchi
2025-10-23 18:49 ` Tom Tromey
2025-10-23 17:17 ` [PATCH 2/2] Free multidicts from blockvector Tom Tromey
2025-10-23 18:31 ` Simon Marchi
2025-10-23 18:52 ` Tom Tromey [this message]
2025-10-24 14:08 ` Tom Tromey
2025-10-24 16:25 ` Simon Marchi
2025-10-24 18:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873479bgdf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox