From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4YeBO60lp2mNwRIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 13:17:18 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VaT1HVdd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DB99C1E089; Tue, 03 Mar 2026 13:17:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A6F81E089 for ; Tue, 03 Mar 2026 13:17:17 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 906C74BA2E1C for ; Tue, 3 Mar 2026 18:17:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 906C74BA2E1C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VaT1HVdd Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 6BC4F4BA2E0E for ; Tue, 3 Mar 2026 18:16:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BC4F4BA2E0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6BC4F4BA2E0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772561803; cv=none; b=epN/roz7B0tYN9aM1NfCGOIugKp75HinOMk8AVVMhiYC5S6s/wFaebrFK9eQ152p2J+7vYQkgHzqBrGnyUW37Y7wPrUeI7MvDcUAfBGNM4buCrgQ67kJPGeAzrOJ4AN3DlC6GDgiopckOuiMExL8oby3E35TdYTnbBcOZuNvkv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772561803; c=relaxed/simple; bh=xEPn6to3GqQNEQ7VUG7G7F9QdR/9pKTMGM1HbHQcWBk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c6dZRC8RMvjwT9Ypsz08fqiVDdtfqHDcJlfdVltb1XQ9scmUzbfCbIWDkUgYK2dJGSrXEnb7Yda8pkZ9VPDYlXsiRJXNZwzwmvlo9zLuK8CyNgPBz4y0JUAnmO9xOGOkxTIqRROCx0OLaCYwMau6s5L0MTzi5ek5DQtqh7jEEuw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BC4F4BA2E0E Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id xJjfvSHRaJ9SZxUIUvTm1M; Tue, 03 Mar 2026 18:16:42 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xUI7vB0PAOs9RxUI8vR4P7; Tue, 03 Mar 2026 18:16:20 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=69a7258a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=JvkqFlM56jmMVMbNLpEA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q/lffrRPBqOtOxqlJImulh98m00wTJPB2y6YADgLXDU=; b=VaT1HVddIXcghOVslRTxq7rQXc QgHZ2Tc2CVXCBxlAui69uq2XrDTtfvR+zx5U3zOrj6RXw5FDVD2SoGpOhEozWA5n78GFXPHuGvGbK eTEArbNbE4hYFPiXe9e7ovG3G; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:37876 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxUI7-00000001HLf-2F6F; Tue, 03 Mar 2026 11:16:19 -0700 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v2 2/9] gdb: introduce rgb_color type to simplify existing code In-Reply-To: <20260303161659.397427-3-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 3 Mar 2026 16:16:52 +0000") References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-3-matthieu.longo@arm.com> X-Attribution: Tom Date: Tue, 03 Mar 2026 11:16:18 -0700 Message-ID: <87342gsrrh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vxUI7-00000001HLf-2F6F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:37876 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGsmux+0bCX+ylUYF4RW7ECbxkdWlcV/BU2PpdbA4W0RLX1p4Kax6kPg728VD3mY9W/5otnnFUk6Jlu8GDKQ5/DvpT92AbhGgL+tMYDUoUpVpQ8AZZRt S8nLstH9dnqUKAm+XSwJGbDFBAjdFED805va3sonE1c+UJxyV/9DZfbFkzt26IZr0bwu0Q3n541CKPXmutASwaWk8h7C8Dq1ySs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > This patch replaces the raw uint8[3] buffer used to represent RGB values > with a more convenient wrapper, rgb_color, around std::array. > It also changes the return type of ui_file_style::color::get_rgb to > rgb_color instead of filling a caller-provided buffer, and updates all > callers accordingly. Nice, thanks. > else if (m_color_space == color_space::ANSI_8COLOR > && 0 <= m_value && m_value <= 7) > - memcpy (rgb, palette_8colors[m_value], 3 * sizeof (uint8_t)); > + memcpy (rgb, palette_8colors[m_value], rgb.size_bytes ()); > else if (m_color_space == color_space::AIXTERM_16COLOR > && 0 <= m_value && m_value <= 15) > - memcpy (rgb, palette_16colors[m_value], 3 * sizeof (uint8_t)); > + memcpy (rgb, palette_16colors[m_value], rgb.size_bytes ()); > else if (m_color_space != color_space::XTERM_256COLOR) > gdb_assert_not_reached ("get_rgb called on invalid color"); > else if (0 <= m_value && m_value <= 15) > - memcpy (rgb, palette_16colors[m_value], 3 * sizeof (uint8_t)); > + memcpy (rgb, palette_16colors[m_value], rgb.size_bytes ()); I wonder if the types of palette_8colors and palette_16colors should change as well. Then it seems the memcpy could be an assignment. > diff --git a/gdb/ui-style.h b/gdb/ui-style.h > index fca9150889b..72349256034 100644 > --- a/gdb/ui-style.h > +++ b/gdb/ui-style.h > @@ -54,6 +54,34 @@ extern bool color_space_safe_cast (color_space *result, long c); > /* Get the number of colors supported by the terminal where GDB is running. */ > extern int gdb_get_ncolors (); > +struct rgb_color > +{ Usually in gdb we add a comment before a struct definition that explains what it is about. > + constexpr const uint8_t& operator[](std::size_t idx) const noexcept > + { return m_data[idx]; } The "&" should come after the space here. Also a space between "[]" and "()". > + color (const rgb_color &rgb) > + : m_color_space (color_space::RGB_24BIT), > + m_red (rgb.r ()), > + m_green (rgb.g ()), > + m_blue (rgb.b ()) > + { > + } Probably this constructor should be 'explicit'. That's the norm in gdb unless there's a real need for an implicit conversion. thanks, Tom