From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0UH0MEw+4mmMyx4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 10:06:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hFqDpVSK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C4C621E0C3; Fri, 17 Apr 2026 10:06:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3C9A31E0B1 for ; Fri, 17 Apr 2026 10:06:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D2D614CCCA0E for ; Fri, 17 Apr 2026 14:05:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2D614CCCA0E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hFqDpVSK Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 2F5F74C515D9 for ; Fri, 17 Apr 2026 14:05:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F5F74C515D9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2F5F74C515D9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776434732; cv=none; b=mkxDaboQ5yKBIXPV+UzC6fDrtWlHOtFKU0xDQYs47HlG+TATwwXwquWSLF8tnxS49b8yb/RxW2oDwrmBt+FhV61ZDj2l5SHGQP4THPhoYCy1kGlZprw9mtjCrR+YOjjWfslSgdoeWxMsPBkSdlHPloZV5ZXklHVc79NP5He26Jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776434732; c=relaxed/simple; bh=219SSq5qHXaUM9z73RffOSKXjpnfuiGWM9Y9ildVFE0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dtZLdHh5PyCUvDAPtvZtxeak17b0PWsrPV1EkgJTAqoFUgpW4E6Ax0aH7haulBR94p8Kac+ybSJEyKJpXICTFaXj9tTk5Vtc4JKBQ69oNAt4++fq+24JYY/2ohyPV3eFh3gxkUF+P9Mif26+ZJ/ppgZ1Azx0upcrzGnJjcWrVf4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F5F74C515D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776434731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QA6zKijAmOSvSvMaGW+1Vz92Z4PcAaQYVEHZAwxvwto=; b=hFqDpVSKwwhx7VuYBSY3JvBkfHx6ed65Al5Rbll7O5Ko8u1ZP/97qnhO/5yyWD4O5oXX33 g+bZFoZzvpU2okLmQ7Rt79mJqcMWbm9ifuiVO82HYBmjUzEPg+4kOEIrjCP4UiebgIWmOf 3mZiYW9uYDZ3tZ60RqfIcUXfNyKsHyw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-1gzOTiz9NQ2UhIDFfOfOyQ-1; Fri, 17 Apr 2026 10:05:30 -0400 X-MC-Unique: 1gzOTiz9NQ2UhIDFfOfOyQ-1 X-Mimecast-MFC-AGG-ID: 1gzOTiz9NQ2UhIDFfOfOyQ_1776434729 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488c2764f83so5364395e9.2 for ; Fri, 17 Apr 2026 07:05:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776434729; x=1777039529; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QA6zKijAmOSvSvMaGW+1Vz92Z4PcAaQYVEHZAwxvwto=; b=ov/gfLvNC3b1c7vA8PnrAkZzWhiBDBlXWmlx0xlKoMQ5oZ7ZNdJUxJBH2ajoXF+M1c UsI73Opo5sHgiHsjbhVDc3nvv8LE1+8veF04bewZL5vh9f9N6dsRS8zb5Nypf/xfHV7/ 1dOwLooyTs4bKx23CtOXCIExmIh5ebgI7J7E+Ql3kmXYezGzyhT8z2j3zINDKl7G9LzQ ytGnD7wEbIcoAO1ICEXS4ToPl6i+Elr7lF9nVTbb/VIY+SPilZ6tc74fHbru5L2dK5zE +cquT9pK149mKJP74Ov+OO9jFT1yKadrV3PNFFCj/Nadl3bzTb6HvUiN4PqSyT+TI1KN 5qMQ== X-Forwarded-Encrypted: i=1; AFNElJ8Oic5nI5S1NwtGaTE5d5nR9QRcplYCY6IN/qV6Vj4JageYsZE4ixf9J/itZnIsYrMxp7FkjJ/NkzRYZQ==@sourceware.org X-Gm-Message-State: AOJu0YzoEKLlZXw4RSHhJfDyb7sNzqDjwYbCNuvweYx8Calb+rLXfffX mYfWerhtZo14+YYkZhrHnzQHThUr2r0xgoN7226QQX+45ytgjXWlAy1KwtYNPcKWPAHlua6UkuP u4mzZdpP4W16qNGKKxhxJebvuTCgc5+Pyi9EvutFxO4kL/RV+kr34e68wzTwlHib3Q+GtJkg= X-Gm-Gg: AeBDievm0PJmrUkJx8ZIMR90IO+LldI4HySN2dhX5qbyCt2Sch5mXujd3wpJesAmleX 3ddClh4jQR7V0Rx0Z+4J5U2wbIcw8EshUns6cahpPvIGaNXnjemjEJ5dc8ZWAItvfDKjByywDfX ERiDpRsXnmA4xwWRKow7Q7B1BMA2gOatYi3w2wlGbFY+2APmDu2cCeIuJuhguNzxpqv89UL5JX6 ne9MKKwAtGKxMJexn+CcX/e9xdHZgQ1RQamV+TU9qk1Le4pBnJnvXgcckvMH1Heu0meg3HCcPXq DgvX5CB6n+qH/kYrNUPg8o5M7KyVs80CEjqN6gP3EMR+LAmZLVNWqxvkSoMxShfh0uoviWhaK8z HVPtx1ODeidont4GM2b4nRCjWNAA= X-Received: by 2002:a05:600c:2d52:b0:488:fd7e:1074 with SMTP id 5b1f17b1804b1-488fd7e131amr14854005e9.2.1776434729008; Fri, 17 Apr 2026 07:05:29 -0700 (PDT) X-Received: by 2002:a05:600c:2d52:b0:488:fd7e:1074 with SMTP id 5b1f17b1804b1-488fd7e131amr14853505e9.2.1776434728440; Fri, 17 Apr 2026 07:05:28 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc14104dsm47162815e9.13.2026.04.17.07.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 07:05:27 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 11/11] gdb: make iterate_over_symbols return void, rename to for_each_symbol In-Reply-To: <20260416202408.422441-12-simon.marchi@efficios.com> References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-12-simon.marchi@efficios.com> Date: Fri, 17 Apr 2026 15:05:26 +0100 Message-ID: <87340tel7d.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HGGbzG63cWAGhO6MCoyAWhSofwME1vC3xZ1c3g8xIZI_1776434729 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > From: Simon Marchi > > Nothing really uses the return value of iterate_over_symbols and > language::iterate_over_symbols. Also, all provided callback always > return true, iterating on all matching symbols. Simplify them to not > return a value and not have the "stop iterating" feature. > > Rename to for_each_symbol, just to be consistent with previous patches. > > Also rename symbol_found_callback_ftype to > for_each_symbol_callback_ftype for consistency. > > Change-Id: I55ff3162098bb069dc1de1afca10dd9abfc05c34 > --- > gdb/ada-lang.c | 26 ++++++++------------------ > gdb/language.h | 13 ++++--------- > gdb/linespec.c | 38 ++++++++++++++++---------------------- > gdb/symtab.c | 23 +++++++++-------------- > gdb/symtab.h | 22 +++++++--------------- > 5 files changed, 44 insertions(+), 78 deletions(-) > > @@ -5665,7 +5660,7 @@ ada_add_all_symbols (std::vector &result, > else > { > /* In the !full_search case we're are being called by > - iterate_over_symbols, and we don't want to search > + for_each_symbol, and we don't want to search As you're touching this comment anyway, could you fix the first line please, the 'are' is not necessary: In the !full_search case we're being called by ... > @@ -2806,26 +2806,18 @@ using find_symtab_callback_ftype = std::function; > std::vector find_linetable_entries_for_symtab_line > (struct symtab *symtab, int line, const linetable_entry **best_entry); > > -/* Prototype for callbacks for LA_ITERATE_OVER_SYMBOLS. The callback > - is called once per matching symbol SYM. The callback should return > - true to indicate that LA_ITERATE_OVER_SYMBOLS should continue > - iterating, or false to indicate that the iteration should end. */ And again, I complained about this in the previous patch review, but you've now removed it. So again, apologies. Approved-By: Andrew Burgess Thanks, Andrew