From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SbHRF54C42kiaCMAWB0awg (envelope-from ) for ; Sat, 18 Apr 2026 00:03:42 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=md2dvl+7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4A9E41E093; Sat, 18 Apr 2026 00:03:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6A1551E093 for ; Sat, 18 Apr 2026 00:03:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D77E24AA54C5 for ; Sat, 18 Apr 2026 04:03:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D77E24AA54C5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=md2dvl+7 Received: from mail-dy1-x132e.google.com (mail-dy1-x132e.google.com [IPv6:2607:f8b0:4864:20::132e]) by sourceware.org (Postfix) with ESMTPS id 5E9CF4AA54C3 for ; Sat, 18 Apr 2026 04:03:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E9CF4AA54C3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E9CF4AA54C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::132e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776484993; cv=none; b=vCW2FJXcOM5ZNnZKVIBOw1q6VinXtHSEB0uQfEwRxkW1qC4mh+yMPoig78HVWMtHOWjRFaeSkibJNgZLIU8/LOpGLURd3dMehS3FBxXh1f4rOtvIcPuPOfx0otsgSBTTTj38MUDznVeNBQ7XKJy057qF4bBQRcDzzUrusu5y1Ok= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776484993; c=relaxed/simple; bh=MXxZkoAh7SyGCqNGuuqzx8dSoVc41ojh/5OaSfu/CgI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nV28VbfBEpQ3XCBWhskJepeC8Nd67ZI5Ui3x6cljFyh6UNLjTJDXJiUDnYdMN2Pqz5orI+OLPiz7UYbGshNX6/J1h0sjOkWgZ7qDXoO1Zzw2jTs776wO9KTIsVbvuOp+H5M+WjAyDjzgUKxPQxnFcEoX1YYmMYBF7hvfnFiCFEU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E9CF4AA54C3 Received: by mail-dy1-x132e.google.com with SMTP id 5a478bee46e88-2d9916deb14so2575141eec.0 for ; Fri, 17 Apr 2026 21:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776484992; x=1777089792; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=v4KiiXVZWxLx/emK4GkWuo6EBu57bs5O0n7gUiPVNjQ=; b=md2dvl+70WOtRYaCTZ4w64S7CIEBP42AWmxpB4AiVRCVwzxBfRbHBIKOCecuxCE/Hu 6gzxiCPmwg8Hd9VQrcNLtFAoObWMdZZGxqvQoYuDEIycYcsRFQBt6PQakKjvXf+RNVUT EsHFsaNLHhCqqtdJtfz3enGUaK3USoPnNlYfnLG3qY3u2eLOhPT1jASYgnYFFg2Ss2wg ZfHTNmplVqe//JiJ4PXmWug7XZlEjHfOpKQ2wVs5SQg3Nz/cAMf2oKyBRmwiHbBrxb9T QW4jyugVX7JIM2ScAsSjGg5w5I/rtQ44T/h1ajmykC6PhcVG5EDL7d7awUcTbyQJR33x SurA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776484992; x=1777089792; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=v4KiiXVZWxLx/emK4GkWuo6EBu57bs5O0n7gUiPVNjQ=; b=TR5caDQR1XFE1h2pqtk8dPPUIqIU0qQTz3WAjp5stSXxER++Jt7KSGOlO/m9YcxpbU Ke1Djn/ybiSTM8FCH7AkKJ6/UB8GNLey17cqvPVJR3qTBmjXEJxT1/hj7SZ8hUVT4DIe 8nK7FMCddmTVVGByWNAx7SVvdKCB4SjVOz+p58onRjtfuem5wxrj/GgLcka1kSMP0uke AEpILsakQlYB/R2QlT5/GVQ70HXrRJtR2+7tzN67gvYPEcYiraPkVAqb9XCA/f96tejY 7BVJUiPXEkq6Nyq3n40KSlOCms8kYPHgB2HRMYZ1O0qTKj7XkNENtHnIYgP+J1CwG1PY LF9Q== X-Gm-Message-State: AOJu0YysLZ1Bb3PNCdtoEWgsJ7yXAYPAtOPx/nqb+Te+j2htYROAr29S SoMkR2NWR816hwYM1s62nnh3uiJryH+AGncc+SqjyPbpO4ucP2nZYPKBHrC6KXNtWII= X-Gm-Gg: AeBDietYvJyWCgiTdY3koQZKP4lsk275FKgAuc7CjABzeevJJeAU6M4j2Y9o7YBYwiX KaCm62EPbIa5ENLfV+xoRsNz4cJm9l/hHEaLOZSoCxOH9tTvNv5wVddRbneGz3kscenAkXGmvYP fnaoazV0zG3QgAgCWiWrH3LlKUX0MctdymbYSAspMHGus2hIeyK00Xk3sz/q6RmdqVFQnCh9UVy sZYIWCOGcB/BAzzjePIPq6XcaEeXLROrtyioYTEAyWkVKWQzx0PENeie9rEINyUbhuLP+IhNnCQ s3tjcP5BUv/E1U6q+m5di4e79C/5LsMyO+H2Z4bX9vqAvlK9yd0KiNt3HZKq8PBhuHAj4THpq9q Fy/QGRKMWfUGfraRB/st3q7xJS9n5VGLE7Skef/ObL2cxpUKcVkjo9GErW5y3vvKVpQdOvR6dDI VfYx2h7xEOvbjahDh511B6xO3BTaAoLOqpJB39LW/w5JnP X-Received: by 2002:a05:7300:dc05:b0:2e2:d94d:6185 with SMTP id 5a478bee46e88-2e466044594mr2901378eec.4.1776484992217; Fri, 17 Apr 2026 21:03:12 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccce440sm4920098eec.14.2026.04.17.21.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 21:03:11 -0700 (PDT) From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] gdb/record: make record_full_history more c++-like In-Reply-To: <20260415185836.2732968-5-guinevere@redhat.com> (Guinevere Larsen's message of "Wed, 15 Apr 2026 15:58:34 -0300") References: <20260415185836.2732968-1-guinevere@redhat.com> <20260415185836.2732968-5-guinevere@redhat.com> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Sat, 18 Apr 2026 01:03:09 -0300 Message-ID: <87340sc3uq.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > Move some functions to being a method of record_full_history, instead of > floating functions. > --- > gdb/record-full.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/gdb/record-full.c b/gdb/record-full.c > index f3737fdbc1f..c9e66fac578 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -325,6 +325,10 @@ struct record_full_instruction > uint32_t insn_num; > std::optional sigval; > std::vector effects; > + > + /* Execute the full instruction. As a side effect, set > + record_full_stop_reason. */ > + void exec_insn (regcache *regcache, gdbarch *gdbarch); Same comment as in a previous patch: since regcache already has a gdbarch, having it as a separate argument is unnecessary. -- Thiago