From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id waNxB7TCB2o7Uz4AWB0awg (envelope-from ) for ; Fri, 15 May 2026 21:04:52 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=o53/1ie9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1B4A01E0B1; Fri, 15 May 2026 21:04:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A732A1E067 for ; Fri, 15 May 2026 21:04:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 608B2409FCB8 for ; Sat, 16 May 2026 01:04:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 608B2409FCB8 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=o53/1ie9 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id 2D9FD409FCB8 for ; Sat, 16 May 2026 01:04:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D9FD409FCB8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D9FD409FCB8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778893466; cv=none; b=PsuznK8tCqVuhA54ixig/ZbbsE8R1k8ir3Urn4YiiCJIKm+lzspqfoTiAX6vJsqdpjGETA8RbYqv9ouwGjhdqV+uX4irwGtuYC2LYiTb/HdFBpsV+DL1Z5lDT5PvTexCo6iYlXNvfkxtTFAqom7M7kqN/XIM7qII1yOmAjgtTdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778893466; c=relaxed/simple; bh=nW+zmS6J8G23LbfxgkEDPJmCjNhF7TOdQdsK9ZQoCeQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QL8lFeKHfjOQ9GuCr9tq0T9H8bweViJYbzzsI46X8J7XDecUkuARh+ROPZdYsA/oiwx0sCiMOpbBUzlhqu/kI+Fhm/NS4fqSxWKPeYGasGboZiLs2rt1N40GAdi6E4pM1c/Ois5ovj+mHwXJ+xn5n0QMkc5U6udDn9ZcyS/5hO8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=o53/1ie9 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D9FD409FCB8 Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-8c921396e37so6402556d6.2 for ; Fri, 15 May 2026 18:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778893465; x=1779498265; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7sdDrqTZBT1rdkIst8v/lvPH5sVldQv3zi+adDCg1MI=; b=o53/1ie9a1Hh1dEEKUno2HzulKZi1OpYurl1rSJHiMrbZvM29omWSMdjyAXHb6RCc3 Zyix76zz9zbaCYk8VMJTT6YGkcL1+6AYobaqRWih4lsS6zP617q/+5kbD1yeq2SCWVWG o917zCJvBvzpQHuzyKcQppm0XF0zxc979AYZ+/BUboJ4vH/GEIosWkdfAi47OFj10Aj0 1SQt1GX13gesYC+65DMcBJK37H5DJHSMLvVPY0mYC5ECcCVmGv7H2d/fqYxDRoOmnK1e LTxdyCHMPJmcQtnehcu5CelZs1pjcCpcskVuQ8RFLOvqTqThBco3TOfgD5tcHNYL5gMC dDEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778893465; x=1779498265; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7sdDrqTZBT1rdkIst8v/lvPH5sVldQv3zi+adDCg1MI=; b=ZljKNcH9qJVgNhzk0GV5Gd2SLPvl2FTri107GQuY6g2aqSqxmWM8Ima7qdawAZYgnE YJdXtywG/bw4rn5Yoh3zEumbgM1NNljrUotPUOkubddjtK4pwDADlGaAGeEJmQ5lrvZl Xd2Kpi7SjKG9o01aE1opWKr2Z1m8SZhPVQadTbGhWlloHJO867o9qLao/HM4dBStQPAI BMuZlET0xc2wR5riP+HnXWL7JMfS8ZGn8fjD1yXqxFI28fypsYj/vOFs6OXP1eboEkWr Dw5LzGP5v/e0UiSBzj+x5c5j35Nr8OYxlVULhLZeAF2HH1NMjytJxtEIQterba7Si23B mELg== X-Gm-Message-State: AOJu0YyHXhyTKw5tH81DlpX+9iX8a43aze1pi4Z3QV4l+L8Ry/2HvyJa uPs+rqCi4eCo6A3JzdZuuofSWDJm4tJQLUc1iWMJzqLl+M1N4Af2uAB/hJrfK8oPDp5fje0zToA cWPIw X-Gm-Gg: Acq92OGnNugv/aLvlW+xz4nDyUaxfYcR7KNK4J3Ki5hl2aEf5p9RfDhcWeSPRSgDjqz OeH9tzAM1qB/TYjxZqPCzTCjJ27rknSqfdKlvK7OPaduhcTKCm0ROdGZFWKdmjMVtVmDgDDexYr jCiry+ES491EKk86zqb8ncftusbPjuK+p8gHvq1OFu/B80SLCCcYWxDKbjTCmwTuS7l4Uhy4nqR forcgXrhZSxWDDUCdUNYZxb8UaAdpEf0EZ90YJfyumaahLTJN/gRW4PGpjmlsKNT2STJaV1458f 07AgYA8rZrCxrnk3Q5FIEWT3gbICyTrex6Sfu56V9CtouB4bAY1Ggj3vSlUztMg/ibVAdA8SZpR j4/VnnuDm3Npun8JQGSQMsdRTLgqolN1wqlTEdUDk2EsNSct6jj3utjw+LPLCk/auVE4OBZs3fy SGUaEkqORAG/me7A0f6rXbgFgnJdviu4hgH80G1kBzd45R X-Received: by 2002:a05:6214:3b85:b0:8ac:b4b3:3ce2 with SMTP id 6a1803df08f44-8ca0f6fa1acmr118855596d6.41.1778893465485; Fri, 15 May 2026 18:04:25 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8c90b2db84asm67280636d6.29.2026.05.15.18.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 18:04:25 -0700 (PDT) From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 5/7] gdb/record: extract the PC to record_full_instruction In-Reply-To: <20260515163706.3355686-7-guinevere@redhat.com> (Guinevere Larsen's message of "Fri, 15 May 2026 13:37:03 -0300") References: <20260515163706.3355686-1-guinevere@redhat.com> <20260515163706.3355686-7-guinevere@redhat.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Fri, 15 May 2026 22:04:22 -0300 Message-ID: <8733zsyxk9.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > This commit makes it so the PC is not saved as part of the > record_full_instruction effects, but rather gets a special location. > That is because a couple of commands would really benefit from it being > easy to find the PC (especially ones from record-btrace that's haven't > been implemented to record-full yet, such as the ones in PR > record/18059), while also possibly allowing for one fewer resizing of > the effect vector (and saving an entire byte in the process). > > This commit also refactored record_full_read_entry_from_bfd and > record_full_write_entry_to_bfd, to make them methods of > record_full_reg_entry and record_full_mem_entry, and also creates > similar methods for record_full_entry and record_full_instruction. > These could be turned into constructors in a future step of > c++ification, but it felt like too much change for a single commit. > --- > gdb/record-full.c | 386 ++++++++++++++++++++++++++++------------------ > 1 file changed, 239 insertions(+), 147 deletions(-) Reviewed-by: Thiago Jung Bauermann -- Thiago