From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UfZ2BokWYWrSmSYAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 15:14:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ERu6cd0c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 071471E09E; Wed, 22 Jul 2026 15:14:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3874C1E033 for ; Wed, 22 Jul 2026 15:14:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB11B4BA2E37 for ; Wed, 22 Jul 2026 19:14:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB11B4BA2E37 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ERu6cd0c Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 933724BA2E0B for ; Wed, 22 Jul 2026 19:13:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 933724BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 933724BA2E0B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784747629; cv=none; b=ArbPwT40OpTPwoyXQ97d3JKnpDomWW1XGJYrhZHQdbw/7Q19izdTuH/rihc8abIkHxmru35ZxHZf2llBDExzoLbVGeTmP218dIwQzQPlgFiNwKgvBgHwo4h743Y2lxe2+zUC9XdA6XoeiZQkzU6YtOZkTM8QSWwdIcuoeLSxni4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784747629; c=relaxed/simple; bh=fokKu+R17Kim0e7KBN4B0TpcN2Lnu06EkaOSpDmUB7I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=d0uoOD9Ks8DYrZbTF1zMkPRtv5c35+iNvoLeKH+uDNFnBKn432biC2mL9LpM0YTmIS8FmDL/JXTm6cq5s+LEa+v/QcymQ+VlFLKaTRppQLeX3fd52x8SMQvJGmw9FKUYm+YHLq4pJxg+7CRdY2wZ4Az8cqifdpKJ7QoVsXaaSJI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ERu6cd0c DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 933724BA2E0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784747629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/3mROVwBzKS+VsHrdQJYFcL6XkihVjL3+lGDczPFnC8=; b=ERu6cd0cHnipx8g2/PoriQc6AZHWazOe4scEmR5Qk9IONUppss7h91aZmxiEdxOmg39rx4 QYG5zXtoOLWa8Mrts2CKwLidiSHcibb7nXwdm3x6ejX3A0r40j5MatGJlD5YzXrVJJpX/B VK/Bgsumjwvm5fVE9ZYYp19XB1j7mLU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-81czZjjFO2GAwKdkhhRD3w-1; Wed, 22 Jul 2026 15:13:47 -0400 X-MC-Unique: 81czZjjFO2GAwKdkhhRD3w-1 X-Mimecast-MFC-AGG-ID: 81czZjjFO2GAwKdkhhRD3w_1784747626 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-493a7fa8481so38227385e9.1 for ; Wed, 22 Jul 2026 12:13:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784747626; x=1785352426; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/3mROVwBzKS+VsHrdQJYFcL6XkihVjL3+lGDczPFnC8=; b=YxVPYKJfvXq8wKxWSHbZqs/V6Xmr7kvyy1vKLXTrQOwOTLIdzeoE2ctRdmmofNS2zC MxwpCdaco/4doE25IoPpDckywRmEIGQykBkjlhkDdHmKOyBvq1tY23guNVHEcX477oSz QfnqKy4iRWQ5pV00F/1ZS3YgxwIAeK12qKHlMYm1jijIEOLflGHbuEwKicOnr2b/4uME Rv8ZihiUbDwRSlyVDJHswaphkEWYYvgVtbij/BS5TPysBaKZKmdO4dte3sUBlmLiVp6N EgYMMhu0arH0KCvHAa7KtQgWSVG3Y/Wz6mPr77OluWRIFiDWgiHNni+gyBffGwh7diGb jRXw== X-Forwarded-Encrypted: i=1; AHgh+RoiBMePaFbkwqJn0AAEd8sWHwyF/0fMZhDN4l3ENPnCHXtrclcOaLe00J7dscL98oxvkmFgscBmZWOYaQ==@sourceware.org X-Gm-Message-State: AOJu0YxI/eTXou6N+wdKFb0RdmV4iIKpyl5YMXxejEgH9VQtUjQCXVr8 ba7Mie203e2zTT5abNM6d8no+krRWwL4+LMJ/y9B3QKjugqQQ6mTfoxXEdJecrakiq3Dgr4yW74 1Pd8irT9epxhISLR8kiVRcBB+y8M1iXdqpcXEPIHQx/7V505vv6baunMyJTD/XiY= X-Gm-Gg: AR+sD12r1uRAdEqfgW6FLDivJ5Hmpvm+JIHU4c0uaLCYNdcUMUz0c3XX8CMSK3EcmOO KbqsvdyI0N7A/9Nmm25ckQ9CTz/ZjyugBo4lcSLHrp0F7D0QT1EYzO6iJeCTzkwS3X7So2ou1Zv ySyN8HhEF1oVAn8LdEhqzlfrAG5LEX8rbwXE3gfygIM85YwJXX5UoJD5JQmfsk4sk1gl5uEfjB5 yQd+qV/GR2D5vcG7UIiuNx4tkk9K98Xh1vHdUbxxAUA8gPS2N4Lx7iu7rjfhf6JmqvH4SODVu8V eAhihhReLDXbHwxQjTAdNZ7O6QE2JBUdW6D7V0UyPHQBYJs7yebMEx3nxlZDhuiyBNLDzSSyY3s fJp/nG09dlZ7sfPW3gVh5S8XD X-Received: by 2002:a05:600c:4687:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4956a4ef4e2mr62025435e9.5.1784747626473; Wed, 22 Jul 2026 12:13:46 -0700 (PDT) X-Received: by 2002:a05:600c:4687:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4956a4ef4e2mr62025005e9.5.1784747625950; Wed, 22 Jul 2026 12:13:45 -0700 (PDT) Received: from localhost (92.40.185.176.threembb.co.uk. [92.40.185.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956ab2f0a2sm60632715e9.1.2026.07.22.12.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 12:13:45 -0700 (PDT) From: Andrew Burgess To: Klaus Gerlicher , gdb-patches@sourceware.org Cc: tom@tromey.com, guinevere@redhat.com, eliz@gnu.org Subject: Re: [PATCH v8 2/6] gdb, cli: remove left-over code from "set_logging_on". In-Reply-To: <20260722102746.131536-3-klaus.gerlicher@intel.com> References: <20260722102746.131536-1-klaus.gerlicher@intel.com> <20260722102746.131536-3-klaus.gerlicher@intel.com> Date: Wed, 22 Jul 2026 20:13:42 +0100 Message-ID: <8733xaq1ll.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: otf6onZKvCnGSZFcByjTzKcw1jsErL-DZBgoTEGEfRc_1784747626 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks for this clean up. One minor comment inline below. Klaus Gerlicher writes: > From: Natalia Saiapova > > This is a refactoring. Remove the left-over code, which rewrites > the logging filename in "set logging on" command. > > The code became unused after the deprecation of "set logging (on|off)" > command. Before the deprecation, the command could also take a file > name and rewrite the logging file, e.g.: > (gdb) set logging on lalala > Copying output to lalala. > Copying debug output to lalala. > > After the command was deprecated and reimplemented as an alias to "set > logging enable on", additional input after "on" became invalid: Here and in two additional places below you say 'enable' instead of 'enabled'. I know 'enable' works fine due to prefix matching, but for commit messages I think it's best to be accurate. With that fixed: Approved-By: Andrew Burgess Thanks, Andrew > > (gdb) set logging on lalala > Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated. > Use 'set logging enabled on'. > > "on" or "off" expected. > (gdb) set logging on lalala > "on" or "off" expected. > (gdb) set logging enable on lalala > "on" or "off" expected. > (gdb) set logging enable on > Copying output to gdb.txt. > Copying debug output to gdb.txt. > --- > gdb/cli/cli-logging.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c > index c9482d59199..33bb42bb444 100644 > --- a/gdb/cli/cli-logging.c > +++ b/gdb/cli/cli-logging.c > @@ -270,11 +270,6 @@ handle_redirections (int from_tty) > static void > set_logging_on (const char *args, int from_tty) > { > - const char *rest = args; > - > - if (rest && *rest) > - logging_filename = rest; > - > handle_redirections (from_tty); > } > > -- > 2.34.1 > > Intel Deutschland GmbH > > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928