From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +b1BOvA8g2p8RC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 12:55:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KBkCX821; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EA4A31E0A3; Mon, 17 Aug 2026 12:55:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A2AE1E033 for ; Mon, 17 Aug 2026 12:55:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16AAD4B99F56 for ; Mon, 17 Aug 2026 16:55:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16AAD4B99F56 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KBkCX821 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7FC744BAE7F3 for ; Mon, 17 Aug 2026 16:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FC744BAE7F3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FC744BAE7F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786985599; cv=none; b=KE9mAW5k0jfvFgKp+6uN0UJhGa/whN+4XAMK91d6Of6v5LP6fscyEjkF2Hp1RNnGkQkN+KaZOB4/OLHOsKM4W69pCLyecEKjHyVK28tavOuOnv5ccToxTT4seYt7KiieQm08yLHcRDfMo4cZwK548QNPiUugTnfBUGxglajneXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786985599; c=relaxed/simple; bh=tSaeJIxv+vWuBM/kVAJO01OI2W3ZpFisTINltvxUUSE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sPt5gaTXLZCnEP1jJRArc59MjUZ531/taBZW2LXf/qKkoy+SoUev4gpiBfnE9uT4WO4cxESt/sEMwjFXHqZhKa+g49eGhSbbPqk8Z44XydXQIzX1z83UpCCLJfOSQ2T/JxuOHXP3fG8IURTfwriHrbr+FoSQ6LzHDJ978RiC8D4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KBkCX821 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FC744BAE7F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786985599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JUNX2HRqPNo71lmD1NMg5IJzCeCRPvha4CI/b+PzQDo=; b=KBkCX821r6zvP6q371+n0R4ERnLvi8J3fWOR2vD7w1KWhFFVPiEsXDG3nJxFnZ16aPO/WH Ot3kiyH8piFgmK0MGbuaXeLNMrwiLUYQk32YN9ZF++T1Iq5AR1dLc8J8ZQ0kZzW4bZz6f1 FFXCppCtYGWGspRfOpR9+Pf9rmgA5vI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-q-OFa9vFN9aBpFEl0GH-iQ-1; Mon, 17 Aug 2026 12:53:11 -0400 X-MC-Unique: q-OFa9vFN9aBpFEl0GH-iQ-1 X-Mimecast-MFC-AGG-ID: q-OFa9vFN9aBpFEl0GH-iQ_1786985590 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4994d67d0e3so27184885e9.2 for ; Mon, 17 Aug 2026 09:53:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786985590; x=1787590390; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JUNX2HRqPNo71lmD1NMg5IJzCeCRPvha4CI/b+PzQDo=; b=E87idy5j3x24sEAPsiqYnQNa44S9h8+oYHRxfu/GlwAaNUa7mTy3JFsDslRs6nyNrS xeOoTi4oOm/0XxwuYNzXNGIcZLVhzPK4lQTh8IwZC6VAi5fC5+eV54elWT2Sq0g+9qpB ZdpG3DSVjdUQOk1f5BCKEaJbrGFRTgAHOj//r5VTacCaKsX+5QnYOho76/YbZM57hUhd pzsbrKxlAmv17/DmaVMLbGXZHC2GbNWTHjFktPVjiy+AM9YfGUwYLkcnPzj+c63MPjAE uVkQnzAzebW9i47H95PEedy5F6aTdcw5g1LVYmcWIezCBx3P5L5VKEccAh2UXuh5DHze 1r7g== X-Forwarded-Encrypted: i=1; AHgh+RoyPNIAI4VXmUZqcTAImvou1OsaErqqX6Jt+PVanIZ/twwz81ZmzH2XWxZIh+3oyVGa0HdrEUmEtf0CQg==@sourceware.org X-Gm-Message-State: AOJu0Yzt+xv3GEbKDJDfQw57BDNKMRjRe7GJ9VctzMaRTamZphIgvymR Dbdgj1W340TEqXEhdPsR8kVfbIuqFk3KBcFVg/YSt7UftlVSvmIps9XRNm4An5uohrva6jUgdy8 q3PxJ8CiX78r1+2iChjnL/4KDRuQ/s6nLRAMmAYmusNQYrYJR1fz4CZxWDbe1wsXFc4dsn2A= X-Gm-Gg: AR+sD13h3FDvq8QfrVN8zQz3+3Fv7ltq8pIXs2Nu0OHf/3syBYH+/L5odRyYdlPSo8d vRgnnY61K+ycehJwpidpq6o8uy7P0clreM9xnAuMl9kVwM80IpDDrCRdJrmU+6v4skLmbkedaLo u0UGxisP/PoUEnA+Yoy8ZTvfWgnB9C6nFeqoq2mk4RJ+pWYVupZXBSJ8E0i/T//Wlw04IR6/jO7 EBc6IzfOZHdmPiZff0vDaF0XxBdxXsMhydcwWoYHSTTHWStnO1vZwCEqLnFuXzOnlsepnnMurzV MDsvOkwa6O+hsA4jKO6P+mq9hE18hNQ76QyV8Njbuax1uCGxINsLGWp63MKRagRjunMqA9Xd4yG 663rCC0TMoTZi5SrxY84= X-Received: by 2002:a05:600c:8b23:b0:499:8b47:ae74 with SMTP id 5b1f17b1804b1-4998b47aedamr333633935e9.16.1786985590501; Mon, 17 Aug 2026 09:53:10 -0700 (PDT) X-Received: by 2002:a05:600c:8b23:b0:499:8b47:ae74 with SMTP id 5b1f17b1804b1-4998b47aedamr333633285e9.16.1786985590084; Mon, 17 Aug 2026 09:53:10 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b783c6sm5516109f8f.31.2026.08.17.09.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 09:53:09 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 11/13] gdb/remote-fileio: remove uses of sprintf In-Reply-To: <20260817151646.152571-12-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-12-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 17:53:09 +0100 Message-ID: <8733wc3czu.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lnSoee0ajvT38ZQBybW6_ZoxFqofiTmpYb19LlXZ7LI_1786985590 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get some: > > /Users/smarchi/src/binutils-gdb/gdb/remote-fileio.c:264:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > 264 | sprintf (buf + strlen (buf), "%x", retcode); > | ^ > > The reply built in remote_fileio_reply is made by appending to a fixed > size buffer, using a mix of strcpy, strcat and sprintf. Replace them > with the safer xsnprintf and xstrcpy. This way, every write is bounds > checked. See previous commit for thoughts on xstrcpy. But otherwise, this looks fine. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I8446a98be5c5fc0eda79ccbc4858d9dddaf2d4d5 > --- > gdb/remote-fileio.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/gdb/remote-fileio.c b/gdb/remote-fileio.c > index a151161371da..297e3337e2fe 100644 > --- a/gdb/remote-fileio.c > +++ b/gdb/remote-fileio.c > @@ -253,28 +253,37 @@ static void > remote_fileio_reply (remote_target *remote, int retcode, int error) > { > char buf[32]; > + char *p = buf; > + char *const end = buf + sizeof (buf); > bool ctrl_c = check_quit_flag (); > > - strcpy (buf, "F"); > + p += xstrcpy (p, end - p, "F"); > + > if (retcode < 0) > { > - strcat (buf, "-"); > + p += xstrcpy (p, end - p, "-"); > retcode = -retcode; > } > - sprintf (buf + strlen (buf), "%x", retcode); > + > + p += xsnprintf (p, end - p, "%x", retcode); > + > if (error || ctrl_c) > { > if (error && ctrl_c) > error = FILEIO_EINTR; > + > if (error < 0) > { > - strcat (buf, "-"); > + p += xstrcpy (p, end - p, "-"); > error = -error; > } > - sprintf (buf + strlen (buf), ",%x", error); > + > + p += xsnprintf (p, end - p, ",%x", error); > + > if (ctrl_c) > - strcat (buf, ",C"); > + p += xstrcpy (p, end - p, ",C"); > } > + > quit_handler = remote_fileio_o_quit_handler; > putpkt (remote, buf); > } > -- > 2.55.0