From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id K4xAJ5ZEpGqj9QAAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 14:12:38 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=EpPoF4C3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8D6651E09E; Fri, 11 Sep 2026 14:12:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6309F1E033 for ; Fri, 11 Sep 2026 14:12:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3EFE548A081A for ; Fri, 11 Sep 2026 18:12:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EFE548A081A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=EpPoF4C3 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 90DFA4BB5937 for ; Fri, 11 Sep 2026 18:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90DFA4BB5937 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90DFA4BB5937 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789150330; cv=none; b=YAPF97vKNLcFwRXILB5z3wHFP2uzDIjHcRhK27il3lJjw1zHp8rr1PmygmUj5dEGfsKoUU6foiHyUuLT1SPSCaL3eTMpsvKVM/gHvp+jSYGMwEKZ6X61kope/jsRM54ZxRr54QR0cRVm8zMb4cAMW71VPjVJzBh4DBCdgM5J168= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789150330; c=relaxed/simple; bh=wZSnyMo+gSsyJZObJyCBKOEFmRjPkaGrJiIDdS0ENho=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=t3PCUCuAcBYnGjHq1tM15qk+yeqLqRYsK7kk1LHzIoH/iMPR6GSGSJ5Mz63a2eODOV+1TDhScACBrr3K+akxteNR25J2O2KjGVIFUnx9Mp264k650lrLdVRzyK70IatgH8sTAU5t/XSVcAsv2u5ZjUT2EODi5/A62WAz62dNNig= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=EpPoF4C3 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90DFA4BB5937 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id 53Oox79fIuFzg55jNxJLDn; Fri, 11 Sep 2026 18:12:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 55jMxMxbQ0FbV55jNxNA7F; Fri, 11 Sep 2026 18:12:09 +0000 X-Authority-Analysis: v=2.4 cv=Nv7Rc9dJ c=1 sm=1 tr=0 ts=6aa44479 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=MxZA0cdYYyuihnZhnB0A:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RYTJVl2UFdFujZUPMBaFjmqiMLlGihVv5wh4VtFxhoY=; b=EpPoF4C372zLF0Wqn7zLnEHdQn i43x8R+0SXTYWHj3xQfR1CT9V0kSuAbjJ/k3tWfti7e7nud0SFQGDjrvHLb7FjAU9uUiicu0iOzQ2 EwF9H8h87DfGYFOPIbEH2mE2M; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:40408 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x55jM-00000001VZn-2MXI; Fri, 11 Sep 2026 12:12:08 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/7] [gdb/tui] Fix underflow in tui_find_backward_disassembly_start_address In-Reply-To: <20260909094849.2745086-3-tdevries@suse.de> (Tom de Vries's message of "Wed, 9 Sep 2026 11:48:44 +0200") References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-3-tdevries@suse.de> X-Attribution: Tom Date: Fri, 11 Sep 2026 12:12:07 -0600 Message-ID: <8733vfzmh4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x55jM-00000001VZn-2MXI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:40408 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEw+xGPAQiO/PDeC9rVajRt++kcTGegSHQhbcHydz+AoKCSTaIZuZnnvnGs6HDX94/eE9P2NC/NP+xth3IKqCBOynmFHXc5PM9LPCZmp8fdOpXYjFX23 /JiO0DRLOPvkhxDP6npwEr/QcYb16wSeiMgpbw6bFUgwXxm57InxvxuyeHoWtpR6HUWoKCVzs/c14NE3qhjm+xVzRK+5OZNa5Qw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> In the tui-disasm.c selftests, we do: Tom> ... Tom> SELF_CHECK (tui_find_disassembly_address (gdbarch, 0, -1) == 0); Tom> ... This test seems nonsensical to me. Tom> + if (addr == 0) Tom> + { Tom> + /* We cannot go backwards from zero. */ Tom> + return addr; Tom> + } Like even if there is a section at 0, would there ever be code at 0? Tom