From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KYTsEdjss2ri7zcAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 11:14:32 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZHVkwFAf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 428A71E06B; Wed, 23 Sep 2026 11:14:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C72951E01F for ; Wed, 23 Sep 2026 11:14:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5776B4BB3BA6 for ; Wed, 23 Sep 2026 15:14:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5776B4BB3BA6 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZHVkwFAf Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 10A704BB24F8 for ; Wed, 23 Sep 2026 15:14:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10A704BB24F8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10A704BB24F8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790176442; cv=none; b=bgM5xA87kuzPGENK0S6J3iJwky5MARrAtVJQuKvFtqPQj+/IGickUKDKa47bDwHeYaNGCUaujohxrS2fvF7Uhum1lIyhBRK2q5aMj4bELelo0kWFWTASA0y5ZQ0AuBYMEiq8sKlB+zP17/aJWM/zgqCIjLU8StBDHE0A8tYf6lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790176442; c=relaxed/simple; bh=Bng6WwtAPdg19NeIIkJfOWkFfK0uRBIJWSsGGtHfC5I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fXe6/d8lbgn3dAVQOZK/zpUEz4/DPqYeM62Wp5usMhWwnwwrmLdT4I+kKr6eQBIa/hoDiPlCe8rmukkvwgF0h4rIooaAL1Uj13n9p/BsibZtPWI+xqO3j/D3KcAxcSDJ0I9UsQA+OoQWj5nN3hJsYW5R9xyoFRr+x6xBN4+0Y3Q= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ZHVkwFAf reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10A704BB24F8 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id 9NhHxvXNgc3Xs9OfXxDu6Z; Wed, 23 Sep 2026 15:14:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 9OfWxXboTP7wg9OfWxLN1W; Wed, 23 Sep 2026 15:13:59 +0000 X-Authority-Analysis: v=2.4 cv=NMzV+16g c=1 sm=1 tr=0 ts=6ab3ecb7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=0iy2iR54QtX2xMWM7kUA:9 a=tFBD-najfWgA:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=giMHmxEIW8e7gJM3l+AV9G0ObIkaZa4QXXwHY909AZY=; b=ZHVkwFAfXrCrJyAuiVaTSv885W XQJXBneki7LFMug81T3BGfGFcvNf9+4uBlN6uoUIb+47CfDi2MYYi4hr0u0vixjwi5QNIqRV0vUph e4i3F4kKnS+oBhgIrdISUslDG; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:37200 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x9OfW-00000002NcR-0UO9; Wed, 23 Sep 2026 09:13:58 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, binutils@sourceware.org, Simon Marchi Subject: Re: [PATCH v2 4/4] gdb/dwarf: fix reading DW_FORM_addrx with address size of 2 In-Reply-To: <20260921173951.688121-5-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 21 Sep 2026 13:39:44 -0400") References: <20260921173951.688121-1-simon.marchi@efficios.com> <20260921173951.688121-5-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 23 Sep 2026 09:13:55 -0600 Message-ID: <8733v0j8zw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x9OfW-00000002NcR-0UO9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (bapiya) [75.166.229.74]:37200 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCR8Adr3eawuevnoNTXK3eEaaKT4xcI+NfcK9nXvyCbkwipFg/RIEK/xSmi4++hiSPCK4/m8xBGYUHauKwHwm6/+nIcQIJqutopvzpxSujYKWPiy+hda Eazc+3TRQ+rMbzL+5DtnW2YMmjyTSxTATNqmHsDa+RKVLhoV2DPpa1fgNnVsYfHQ+ELzdXNotcznJJjB7cONzk3yDQnFVR37sKQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> @@ -14658,25 +14660,34 @@ read_addr_index_1 (dwarf2_per_objfile *per_objfile, unsigned int addr_index, Simon> + ULONGEST entry_offset = static_cast (addr_index) * addr_size; Since the only use is in a cast to another type, perhaps the type should just be ULONGEST in the signature. Tom