From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2468Al2W2GoZPQIAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 06:39:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=C4fBvz5u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CAFEE1E047; Wed, 21 Oct 2026 06:39:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DATE_IN_PAST_12_24,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E71581E047 for ; Wed, 21 Oct 2026 06:39:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 518ED4BA23D9 for ; Wed, 21 Oct 2026 10:39:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 518ED4BA23D9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=C4fBvz5u Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3DB894BA2E28; Wed, 21 Oct 2026 10:37:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DB894BA2E28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DB894BA2E28 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792579064; cv=none; b=hbx1kaIHeOAueS+0ewPIM5uV29Xq7g0oE1e//WPSQTG0BORqwCF2aL9yWhbXLh9ld+nWP7PmS9V/SPukGF+C4uqZMFiHJbWA6QksgEKnWl3FgsLxQ3kWPKff3BlR6fsi5FFyBpHcggPNmlPHGhMiGV4LihXJ+WIKBit1AGxSuOE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792579064; c=relaxed/simple; bh=DdslOvGE4jzugs/XVhJ2/HdhIEVWpVbeD9SeR80S2y8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VcjrM7hY3xi5WAANwvlXCFb1s7YibD4ilml5b43WO/Vg+5EqRBNkyWGlXQl8XWWTOxN54F63lQuhnMssXvwrnIgcIiTfQTiAibBgXXn3cmDVTGreBycK91VSEj89ni7FGg9qow2cJ2uCJbu2jyMXLJY9o4W5HGQ/xZByfIgCu4Q= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=C4fBvz5u DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DB894BA2E28 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJThX-0003OQ-2N; Wed, 21 Oct 2026 06:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=3DrUOX66w3UBfvvZpOgo8kfIv2XH4Vq8RJNB71Rbus8=; b=C4fBvz5ukQrPofBbstz0 aSXUwplGIkZhNqtJfLSZ0daZpA++sAmmwLtRRR3Ka22zuMQlMiAiRAJq8O5+7ylKozVXxFthF4Gys zRvCtpjqZ/Tt2HElKBmjibzwvDs0Mrtrc+EC3dVWKqaKfFtjitD6YBQvC5WPjtkvtIavnE8XmrDT9 aL+IR5Ut0SWcbHm0rtf+w7BFkQmawKybvDVmi/xbHCEMFu+iNpc7GPEYnM+uXhunGi9gjcxBErM/q FStlJdGJLlfvY7YIhA+rO5djAu3qkNCQn5LIaKEK9jjG16G9e941BuIHO6hk7F795kXoV8q3uKUwm k2TiiNmtNqH0sQ==; From: "Jose E. Marchesi" To: Simon Marchi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 09/18] sim/bpf: remove unused bpf_program_section variable In-Reply-To: References: <20261019193231.1708375-1-simon.marchi@efficios.com> <20261019193231.1708375-10-simon.marchi@efficios.com> Date: Tue, 20 Oct 2026 12:59:50 +0200 Message-ID: <8733u0d4d5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Simon. FWIW the change LGTM. Thanks. > Adding gdb-patches@. > > On 10/19/26 3:28 PM, Simon Marchi wrote: >> Building the BPF simulator with a recent clang fails with: >> >> /home/smarchi/src/binutils-gdb/sim/bpf/bpf-sim.c:367:14: error: variable 'bpf_program_section' set but not used [-Werror,-Wunused-but-set-global] >> >> The --bpf-set-program option stores its argument in this variable, but >> nothing ever reads it, the feature was never implemented. Remove the >> variable. >> >> Change-Id: I71edbed055a82fb65a2acecbc38477e3ded80d6a >> --- >> sim/bpf/bpf-sim.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/sim/bpf/bpf-sim.c b/sim/bpf/bpf-sim.c >> index 9cb272a240e5..34f78c91bc30 100644 >> --- a/sim/bpf/bpf-sim.c >> +++ b/sim/bpf/bpf-sim.c >> @@ -362,10 +362,6 @@ bpf_pc_set (sim_cpu *cpu, sim_cia pc) >> >> static int64_t skb_data_offset; >> >> -/* String with the name of the section containing the BPF program to >> - run. */ >> -static char *bpf_program_section = NULL; >> - >> >> /***** Handle BPF-specific command line options. *****/ >> >> @@ -416,7 +412,6 @@ bpf_option_handler (SIM_DESC sd, sim_cpu *cpu ATTRIBUTE_UNUSED, int opt, >> case OPTION_BPF_SET_PROGRAM: >> /* XXX: check that the section exists and tell the user about a >> new start_address. */ >> - bpf_program_section = xstrdup (arg); >> break; >> >> case OPTION_BPF_SKB_DATA_OFFSET: >> -- >> 2.56.0 >>