From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MS4HFKYo2WogvggAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 17:03:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Hsq42rje; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1BFA51E051; Wed, 21 Oct 2026 17:03:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 61F0D1E04D for ; Wed, 21 Oct 2026 17:03:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4156E4BA23E7 for ; Wed, 21 Oct 2026 21:03:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4156E4BA23E7 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Hsq42rje Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 50D084BA2E16 for ; Wed, 21 Oct 2026 21:03:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50D084BA2E16 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50D084BA2E16 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792616587; cv=none; b=YCPco9xjyw9/Jaks+FiloAvzAdFH4qxEQGlL4P5XoF/B9ZpZoHWzrA3g1+aLhPVcBjjeycSOi4nB6MphsmDvRQ17Pcz58sLEuV8rQDepoUhj4KJ7kEY6kLbyNhTwHS7etYuz0eUms6yU3pOEwA0eX44lV5NXCpoHUxVVQVoPY3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792616587; c=relaxed/simple; bh=dS6NPekAarevCInMBmxjSoG9nW4hJCNHezySQoCcIXI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WPX1P6NlDE1/E17FtG9DLY0T3Kx1m/fC0SsIoug3veMIr6mlJNykI1aLAXLrsthgvyRxwa+l/sADHVOTxVhBeUNgSKzPlhxLUuZZ0ErDLaXE2E57F8b7qymBYxw0BYN829AvkHntXB79uf1LH3FArb1zzHoltA40RrYyhxoloRc= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Hsq42rje reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50D084BA2E16 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id Jb2kxXa5TMylkJdSkxQsWM; Wed, 21 Oct 2026 21:03:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JdSjxdAH4vvPpJdSjxg7ny; Wed, 21 Oct 2026 21:03:05 +0000 X-Authority-Analysis: v=2.4 cv=WqUrMcfv c=1 sm=1 tr=0 ts=6ad9288a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=XXyAMCCnRG3qMhhDnGwA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QXZvDy8ZMi0JLKr7hyuOe5rfh+IAJxuG6L1zLiaFWVE=; b=Hsq42rjeDG8eMYO4kQo/DhA7ED v4g+ec3aFXd0RXwgxlVRe2Cuq5J16QyqXFL9QxHO3XsewfEM8tUhf+yPiMe5YlFHGExqvhrLTRM/W 4VSaCa3XdfqPRwfFzdGNz84su; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:40478 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJdSi-00000003VI9-2zid; Wed, 21 Oct 2026 15:03:04 -0600 From: Tom Tromey To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org Subject: Re: [PATCH v11 10/10] gdb: Filter trampoline frames in backtrace when using Python frame-filters. In-Reply-To: <20260803193449.33375-11-abdul.b.ijaz@intel.com> (Abdul Basit Ijaz's message of "Mon, 3 Aug 2026 21:34:49 +0200") References: <20260803193449.33375-1-abdul.b.ijaz@intel.com> <20260803193449.33375-11-abdul.b.ijaz@intel.com> X-Attribution: Tom Date: Wed, 21 Oct 2026 15:03:03 -0600 Message-ID: <8733tyu5q0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJdSi-00000003VI9-2zid X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:40478 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEI/V4g3Yodldq9Ig/VaWCt9Yd4ATfBhsV1JugHTWdoUS2Jv9jIex89FOQWjXNO+pq9zxUTZ5ajHfB7lll3wjouX+AgZurxugBIndbesfWnFdkfetOcX BvPCxAdzKyHsAT43YWLcZHuPCj7zUyUspTL2liaQmadiC2IzUO9cQ6iPG5tSkbSjgMrtHeFlX5AWXxkTFikFYoBK++6ya7zepWY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Abdul Basit Ijaz writes: > In case of the Python frame-filters, this change filters trampoline functions > when the option 'skip-trampoline-functions' is set to 'on'. GDB recently > added the option to hide frames that are marked by the compiler with > "DW_AT_trampoline", see commit 'Skip trampoline frames for the backtrace > command'. This implements the same functionality when python frame filters > are in use. > diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c > index afa89f0d112..098b37230e1 100644 > --- a/gdb/python/py-frame.c > +++ b/gdb/python/py-frame.c > @@ -59,6 +59,17 @@ frame_object_to_frame_info (PyObject *obj) > if (frame == NULL) > return NULL; > + if (skip_trampoline_functions) > + { > + for (int i = 0; (SAFE_TRAMPOLINE_CHAIN (i, frame) > + && in_trampoline_frame (frame)); ++i) > + { > + frame = get_prev_frame (frame); > + if (frame == nullptr) > + return nullptr; > + } > + } This seems suspicious to me. For one thing, suppose you have A -> Trampoline -> B. Then in Python you fetch the frame B. What does B.newer() return? I think with this code it will just return B again. For DAP, and frame filters, I tend to think it would be better for Python to simply see the frames as they are, but then add a new attribute -- on the frame, but also maybe on the symbol -- indicating if it's been marked as a trampoline. Then maybe _FrameDecoratorBase.elided could return True if the frame is a non-"live" trampoline frame. Tom