From: Richard Sandiford <rsandifo@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: cgd@broadcom.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa/mips] Second go at vr5500 hilo hazard fix
Date: Wed, 24 Mar 2004 07:59:00 -0000 [thread overview]
Message-ID: <871xni4qtn.fsf@redhat.com> (raw)
In-Reply-To: <405B0F63.8050403@gnu.org> (Andrew Cagney's message of "Fri, 19 Mar 2004 10:18:59 -0500")
After leaving a bit of breathing room in case cgd or anyone else
wanted to object...
Andrew Cagney <cagney@gnu.org> writes:
>> cgd@broadcom.com writes:
>>>> Now that the mips sim 'multi' bits are in place (including good
>>>> default), and we have MIPS_MACH(SD) (thanks! 8-), it should be
>>>> possible to code a simple macro which checks for the appropriate bfd
>>>> machine, and decides whether interlocks are present.
>> Well, I had a similar check in:
>> http://sources.redhat.com/ml/gdb-patches/2002-11/msg00642.html
>> OK, so it wasn't wrapped up in a nice macro, it just checked the
>> architecture directly:
>> + /* There are no timing requirements in vr5500 code. */
>> + if (MIPS_MACH (SD) == bfd_mach_mips5500)
>> + return 1;
>> But that was exactly what Andrew objected to:
>> http://sources.redhat.com/ml/gdb-patches/2002-11/msg00668.html
>
> FYI, I think the comment still stands - I'm describing how IGEN is ment
> to be used (and is what Richard's patch does).
>
> (Richard thanks for pokeing at this),
> Andrew
Does this mean that the patch is approved?
Richard
next prev parent reply other threads:[~2004-03-24 7:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 15:05 Richard Sandiford
2004-03-19 0:09 ` Richard Sandiford
[not found] ` <mailpost.1079622402.27828@news-sj1-1>
2004-03-19 0:09 ` cgd
2004-03-18 17:57 ` cgd
2004-03-18 20:55 ` Richard Sandiford
2004-03-19 0:09 ` Richard Sandiford
2004-03-19 15:19 ` Andrew Cagney
2004-03-24 7:59 ` Richard Sandiford [this message]
2004-03-24 15:59 ` cgd
2004-03-25 7:15 ` cgd
2004-03-25 7:45 ` Richard Sandiford
[not found] ` <mailpost.1080200738.13330@news-sj1-1>
2004-03-25 18:53 ` cgd
2004-03-25 22:14 ` Andrew Cagney
2004-03-26 0:01 ` cgd
2004-03-26 0:28 ` Andrew Cagney
[not found] ` <mailpost.1080260907.10999@news-sj1-1>
2004-03-26 2:19 ` cgd
2004-03-28 10:16 ` Richard Sandiford
[not found] ` <mailpost.1080469040.8967@news-sj1-1>
2004-03-29 19:38 ` cgd
2004-04-10 6:59 ` cgd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871xni4qtn.fsf@redhat.com \
--to=rsandifo@redhat.com \
--cc=cagney@gnu.org \
--cc=cgd@broadcom.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox