From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23182 invoked by alias); 9 Jun 2009 00:24:34 -0000 Received: (qmail 23174 invoked by uid 22791); 9 Jun 2009 00:24:34 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from qw-out-1920.google.com (HELO qw-out-1920.google.com) (74.125.92.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 00:24:27 +0000 Received: by qw-out-1920.google.com with SMTP id 4so1806118qwk.24 for ; Mon, 08 Jun 2009 17:24:25 -0700 (PDT) Received: by 10.224.54.65 with SMTP id p1mr7469632qag.99.1244507065731; Mon, 08 Jun 2009 17:24:25 -0700 (PDT) Received: from hydrogen.gmail.com (207-172-203-39.c3-0.upd-ubr7.trpr-upd.pa.cable.rcn.com [207.172.203.39]) by mx.google.com with ESMTPS id 6sm434780qwk.10.2009.06.08.17.24.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 08 Jun 2009 17:24:24 -0700 (PDT) Date: Tue, 09 Jun 2009 00:24:00 -0000 Message-ID: <871vpudzkd.wl%naesten@gmail.com> From: Samuel Bronson To: tromey@redhat.com Cc: Samuel Bronson , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame". In-Reply-To: References: <1243638987-4533-1-git-send-email-naesten@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.3 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00197.txt.bz2 At Thu, 04 Jun 2009 15:59:57 -0600, Tom Tromey wrote: > > >>>>> "Samuel" == Samuel Bronson writes: > > Samuel> Have "info frame" display this field when present. > Samuel> Fill in the field for unwinders (besides the sentinel) which are > Samuel> normally built on i386 Linux. > > Funnily enough, I wanted this yesterday :) > > This mostly looks ok. It needs a ChangeLog entry. And I have some > formatting nits... Hmm. How is that different from the thing above the patch (aka "commit message")? > Samuel> +const char *get_frame_unwinder_name (struct frame_info *frame) > > Newline after the first "*". Ah. > Samuel> + unwinder = get_frame_unwinder_name(fi); > > Space before the open paren. Yeah, I've noticed that you always put those in and have been doing so myself more recently. > Also, do you have copyright assignment papers in place? Those are a > prerequisite for us to accept a non-trivial patch. Ah, no, not yet. I assume this doesn't qualify? I'd be fairly happy to do so, my concerns at this point being: a) what if I write some fairly generic code and end up wanting to BSD it? b) how do I know you aren't going to add front- or back-cover texts or invariant sections to the manual?