Re: Testsuite regression for annota1.exp and annota3.exp [Re: [PATCH] [SH] ... can do this signal stuff!]

Thomas Schwinge
2012-02-28T22:46:48Z

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Hi!

On Tue, 28 Feb 2012 20:41:37 +0100, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Tue, 28 Feb 2012 20:08:30 +0100, Thomas Schwinge wrote:
> > 142db50201b1b1c69ebdc2dcdb1181cde1db3b08 I got the idea of using [concat
> > ...] for building gdb_expect_list's third list argument -- it needs to
> > expand $main_line, etc. Any better suggestions (I obviously don't have a
> > lot of TCL and/or GDB testcase writing experience), or is this
> > acceptable?
>
> I find it OK.

Thanks for reviewing this quickly.

> Please edit in your patch:
> > + "Breakpoint.*at.* file .*$srcfile, line $main_line\." \
> ->
> + "Breakpoint.*at.* file .*$srcfile, line $main_line\\." \
>
> (as \. is just TCL character . and regex then just gets ., not \.)

Makes sense; re-tested and then committed with that change. There are,
of course, other similar inaccuracies, such as an unquoted dot after
expanding $srcfile in the line that you quoted above, but that's a
separate cleanup project.