Re: [PATCH] traceframe_changed observer and MI notification

Eli Zaretskii
2012-09-18T08:01:39Z

> Date: Tue, 18 Sep 2012 15:23:02 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
>
> On 09/18/2012 02:52 PM, Eli Zaretskii wrote:
> >> +or @value{GDBN} stops examining traceframes and resumes live debugging.
> > This line should be edited to explain the meaning of negative values
> > of tfnum.
> >
>
> tfnum will never be negative in notification. In traceframe_changed
> observer, tfnum can be negative, and notification
> "=traceframe-changed,end" is emitted accordingly.

Then that line should be deleted.

> > Also, I don't understand the significance of the reference to
> > 'tfind'. Why is it important to mention that?
> >
>
> because users use command 'tfind' to examine a certain traceframe, and
> the changes of traceframe trigger this MI notification, so I mention
> 'tfind' here.

The text you wrote can be interpreted as if using 'tfind' was the only
way to change the trace frame. If that's not true, 'tfind' it should
be mentioned in parentheses, something like

(e.g., by using the @code{tfind} command)