From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11238 invoked by alias); 16 Oct 2012 20:16:02 -0000 Received: (qmail 11228 invoked by uid 22791); 16 Oct 2012 20:16:01 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Oct 2012 20:15:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9GKFq7Q006097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 16 Oct 2012 16:15:52 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9GKFpHh009885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 16 Oct 2012 16:15:51 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface. References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> <1349696849-9056-4-git-send-email-sanjoy@playingwithpointers.com> Date: Tue, 16 Oct 2012 20:16:00 -0000 In-Reply-To: <1349696849-9056-4-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Mon, 8 Oct 2012 17:17:29 +0530") Message-ID: <871ugy896w.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00258.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> +2012-10-08 Sanjoy Das Sanjoy> + Sanjoy> + * gdb.base/jit-reader.exp: New file. Test case for the jit-reader Sanjoy> + interface. Sanjoy> + * gdb.base/jithost.c: Do. Sanjoy> + * gdb.base/jithost.h: Do. Sanjoy> + * gdb.base/jitreader.c : Do. Thanks very much for doing this. I was concerned that this test should be native-only, but then I noticed that skip_shlib_tests checks isnative. So, no worries there. Sanjoy> +set include_dir ${objdir}/../../ I think this should use standard_output_file. This patch is ok with this change. thanks, Tom