From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20787 invoked by alias); 13 Mar 2013 20:09:04 -0000 Received: (qmail 20773 invoked by uid 22791); 13 Mar 2013 20:09:02 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 20:08:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DK8nKE010218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Mar 2013 16:08:49 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2DK8lXm031105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Mar 2013 16:08:48 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH v3 03/15] Read CTF by the ctf target References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-4-git-send-email-yao@codesourcery.com> Date: Wed, 13 Mar 2013 20:09:00 -0000 In-Reply-To: <1362800844-27940-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 9 Mar 2013 11:47:12 +0800") Message-ID: <871ubjawq8.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00606.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> +AC_ARG_WITH(babeltrace, Yao> + AC_HELP_STRING([--with-babeltrace], Yao> + [Specify prefix directory for the installed Yao> + BABELTRACE package Equivalent to Yao> + --with-babeltrace-include=PATH/include Yao> + plus --with-babeltrace-lib=PATH/lib])) I think this is missing a period and a space between "package" and "Equivalent", but see below. Yao> +if test "x$with_bt_include" != x; then Yao> + LIBBABELTRACE_CFLAGS="-I$with_bt_include " Yao> +fi Yao> +if test "x$with_bt_lib" != x; then Yao> + LIBBABELTRACE="-L$with_bt_lib -lbabeltrace -lbabeltrace-ctf" Yao> +fi Yao> + Yao> +if test "x$with_babeltrace" != "xno"; then This only checks for libbabeltrace if --with-babeltrace is specified. So, the text above about equivalency isn't really correct, at least the way I read it; if you want to give --with-babeltrace-include, you have to also give --with-babeltrace. I'm not sure how to reword the above to make it more clear. Perhaps spelling out the options. Yao> + Yao> +static void Yao> +ctf_close_dir (void) Lots of functions missing intro comments. Most of the comments can be really short, since these are just implementations of target methods. Yao> + /* Yao> + gdb_assert (mlen == bt_ctf_get_array_len (decl)); Yao> + contents = bt_ctf_get_char_array (array); Yao> + */ I think just delete this. Yao> +static int Yao> +ctf_has_all_memory (struct target_ops *ops) Yao> +{ Yao> + return 0; Yao> +} Unfortunately for you there is plenty of this patch I don't feel competent to review. I don't know much about the target API. If nobody else looks after a decent interval, ping me and I will ok it. I suppose if these methods parallel the existing tfile target, then that is pretty good evidence for it being ok. The rest seems ok to me. Tom