From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28964 invoked by alias); 23 Apr 2013 20:25:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28952 invoked by uid 89); 23 Apr 2013 20:25:00 -0000 X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 20:25:00 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3NKOwU9003710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Apr 2013 16:24:58 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3NKOuoa010271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 23 Apr 2013 16:24:57 -0400 From: Tom Tromey To: Nicolas Blanc Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Test adding and removing a symbol file at runtime. References: <1366098721-18302-1-git-send-email-nicolas.blanc@intel.com> <1366098721-18302-4-git-send-email-nicolas.blanc@intel.com> Date: Wed, 24 Apr 2013 12:18:00 -0000 In-Reply-To: <1366098721-18302-4-git-send-email-nicolas.blanc@intel.com> (Nicolas Blanc's message of "Tue, 16 Apr 2013 09:52:00 +0200") Message-ID: <871ua1ouzr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00717.txt.bz2 >>>>> "Nicolas" == Nicolas Blanc writes: Nicolas> This test exercises the commands 'add-symbol-file' Nicolas> and 'remove-symbol-file'. Thank you. Nicolas> +#include This line seems wrong. It seems simpler to do the test by using an ordinary .so and then calling remove-symbol-file on it. Then perhaps it could even work on some non-ELF systems. Would this not work for some reason? Nicolas> +# 6) Set a breakpiont at FOO in $librc. Two typos, "breakpoint" and "$libsrc". Nicolas> +set testfile sym-file-main Nicolas> +set libfile sym-file-lib Nicolas> +set srcfile ${testfile}.c Nicolas> +set binfile ${objdir}/${subdir}/${testfile} Nicolas> + Nicolas> +set libsrc "${srcdir}/${subdir}/${libfile}.c" Nicolas> +set libname "${libfile}.so" Nicolas> +set shlib_name "${objdir}/${subdir}/${libname}" Nicolas> +set libobj "${objdir}/${subdir}/${libname}" Nicolas> +set execsrc "${srcdir}/${subdir}/${srcfile}" This should use standard_testfile and standard_output_file. Nicolas> +gdb_exit Nicolas> +gdb_start Nicolas> +gdb_reinitialize_dir $srcdir/$subdir Nicolas> + Nicolas> +# 1) Load the main executable. Nicolas> +set result [gdb_load ${binfile}] Nicolas> +if { $result != 0 } then { Nicolas> + return Nicolas> +} clean_restart Nicolas> +# 6) Set a breakpoint at FOO in $libsrc. Nicolas> +set result [gdb_breakpoint foo] Nicolas> +if { !$result } then { Nicolas> + return I think most .exp files don't bother checking each result like this. It is enough for one thing to report a fail; the test may limp on. That said I don't really mind either way. Tom