From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101356-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13661 invoked by alias); 9 May 2013 20:58:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13652 invoked by uid 89); 9 May 2013 20:58:41 -0000
X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 20:58:41 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r49Kwe8Q007120	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 9 May 2013 16:58:40 -0400
Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r49KwcB9027312	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 9 May 2013 16:58:39 -0400
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Cleanup for make_source_files_completion_list
References: <51895A2F.8000504@redhat.com>
Date: Thu, 09 May 2013 20:58:00 -0000
In-Reply-To: <51895A2F.8000504@redhat.com> (Keith Seitz's message of "Tue, 07	May 2013 12:46:55 -0700")
Message-ID: <871u9fj2f5.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-05/txt/msg00362.txt.bz2

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> make_source_files_completion_list is only ever called with the first
Keith> parameter twice, e.g.,
Keith>   fn_list = make_source_files_completion_list (text, text);
Keith> Is there any reason to not whack the second parameter as the following
Keith> patch does?

It makes me wonder if those calls are wrong somehow.

But if those calls are correct then the patch is ok.

Tom