From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28278 invoked by alias); 16 Jul 2013 17:36:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28253 invoked by uid 89); 16 Jul 2013 17:36:52 -0000 X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Jul 2013 17:36:51 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6GHac64024341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 16 Jul 2013 13:36:38 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6GHaZnR005234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 16 Jul 2013 13:36:36 -0400 From: Tom Tromey To: "Andrew Burgess" Cc: gdb-patches@sourceware.org, "Andreas Schwab" , Paul_Koning@Dell.com Subject: Re: [PATCH] Don't call strchr with the NULL character. References: <51DEDA0E.8020809@broadcom.com> <51DFC9C6.2060806@broadcom.com> Date: Tue, 16 Jul 2013 17:36:00 -0000 In-Reply-To: <51DFC9C6.2060806@broadcom.com> (Andrew Burgess's message of "Fri, 12 Jul 2013 10:17:58 +0100") Message-ID: <871u6yl84c.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00367.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> That said, my patch (I believe) fixes gdb given the /current/ Andrew> behaviour, which I thought was undefined, but is in fact well Andrew> defined. Either way I believe this patch is required. I agree. The patch is ok. thanks, Tom