From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28711 invoked by alias); 29 Aug 2013 15:00:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28702 invoked by uid 89); 29 Aug 2013 15:00:58 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 15:00:58 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TF0tmg021519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 11:00:55 -0400 Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7TF0rjZ005346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 29 Aug 2013 11:00:54 -0400 From: Tom Tromey To: Pedro Alves Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch gdbserver 7.6.1 only] Fix fd leak regression References: <20130829111053.GA25662@host2.jankratochvil.net> <521F3B71.1010007@redhat.com> <20130829130359.GA31063@host2.jankratochvil.net> <521F5804.1080604@redhat.com> <87a9k0sgpf.fsf@fleche.redhat.com> <521F5FD1.8020107@redhat.com> Date: Thu, 29 Aug 2013 15:00:00 -0000 In-Reply-To: <521F5FD1.8020107@redhat.com> (Pedro Alves's message of "Thu, 29 Aug 2013 15:50:57 +0100") Message-ID: <871u5csfrv.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00877.txt.bz2 Tom> gdbserver on trunk can just use the filestuff.c code. Pedro> Yeah, it already does: Pedro> https://sourceware.org/ml/gdb-patches/2013-08/msg00765.html Pedro> but it doesn't call socket_mark_cloexec or similars, so we'll Pedro> probably still have to revisit this at some point (years Pedro> from now). :-) Yeah, I meant the other filestuff.h code, like gdb_socket_cloexec and gdb_pipe_cloexec. Tom