From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20050 invoked by alias); 23 Sep 2013 14:02:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20031 invoked by uid 89); 23 Sep 2013 14:02:53 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Sep 2013 14:02:53 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8NE2m3F027591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 Sep 2013 14:02:49 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NE2lla002385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Sep 2013 14:02:48 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NE2ltL007955; Mon, 23 Sep 2013 14:02:47 GMT Received: from termi.oracle.com (/10.175.6.102) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 23 Sep 2013 07:02:47 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: "Tedeschi\, Walfred" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH][SPARC64] Fix breakpointing in syscalls other than sigreturn References: <87ioxradrb.fsf@oracle.com> Date: Mon, 23 Sep 2013 14:02:00 -0000 In-Reply-To: (Walfred Tedeschi's message of "Mon, 23 Sep 2013 13:33:37 +0000") Message-ID: <871u4fab3d.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00819.txt.bz2 Hi. Have you observed some failure to submit this patch? If so could you also provide a test case? I noticed that watchpoints were not surviving ld.so. Consider this test program: int jorl; int main () { jorl = 20; return 0; } If you set a watchpoint to watch writes to the variable 'jorl' and then [jemarch@jemarch1 ~]$ gdb foo GNU gdb (GDB) Red Hat Enterprise Linux (7.2-60.0.2.el6) Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "sparc64-redhat-linux-gnu". For bug reporting instructions, please see: ... Reading symbols from /home/jemarch/foo...(no debugging symbols found)...done. (gdb) watch jorl Watchpoint 1: jorl (gdb) run Starting program: /home/jemarch/foo 0xfffff8010001c444 in mmap64 () from /lib64/ld-linux.so.2 Could not insert single-step breakpoint at 0x1 (gdb) As described in the patch the problem is that single-stepping over 'ta 0x6d' instructions is not working properly. And the reason is that sparc64_linux_step_trap is only intended to be useful when single-stepping sigreturn syscalls and must return zero in any other case. Do you want a test for gdb/testsuite? In that case, what would be the best place where to add the test? gdb.base?