From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9299 invoked by alias); 17 Oct 2013 19:58:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9290 invoked by uid 89); 17 Oct 2013 19:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 19:58:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9HJwp0p006681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Oct 2013 15:58:51 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9HJwn7T021701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Oct 2013 15:58:50 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 08/13] simple changes in gdb.base References: <1377290210-483-1-git-send-email-tromey@redhat.com> <1377290210-483-9-git-send-email-tromey@redhat.com> <521CAA1D.9050405@redhat.com> Date: Thu, 17 Oct 2013 19:58:00 -0000 In-Reply-To: <521CAA1D.9050405@redhat.com> (Pedro Alves's message of "Tue, 27 Aug 2013 14:31:09 +0100") Message-ID: <871u3jvfd2.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00537.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 08/23/2013 09:36 PM, Tom Tromey wrote: >> + >> +foreach file $all_files { >> + if {[is_remote host]} { >> + set this_name $file >> + } else { >> + set this_name [standard_output_file $file] >> + } >> + >> + lappend filenames [set ${file} $this_name] Pedro> Took me a second to realize/notice it's this loop that Pedro> creates the intarr1.bin etc. variables used in: >> +make_dump_file "dump val [set intarr1.bin] intarray" Pedro> etc. How about adding a comment here, or above the loop? Done. >> # clean up files >> >> -remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex >> intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex >> intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex >> intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex >> intstr2.srec intstr2.tekhex intarr3.srec" >> +remote_exec build "rm -f $filenames" Pedro> s/build/host ? Yeah, I think so. I had left it as it was before, but I do think it's wrong. I fixed it here. >> >> -set solib_binfile_target [gdb_download ${solib_binfile}] >> +if {[is_remote target]} { >> + set solib_binfile_target [gdb_download ${solib_binfile}] >> +} else { >> + set solib_binfile_target $solib_binfile >> +} >> Pedro> Sounds like this should be using gdb_load_shlibs. gdb_load_shlibs sets solib-search-path and I think this particular test is also testing for the case where it is set improperly. So, I think switching to gdb_load_shlibs would need even more work. Tom