From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5633 invoked by alias); 28 Oct 2013 20:49:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5620 invoked by uid 89); 28 Oct 2013 20:49:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 20:49:20 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SKnIUN027381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Oct 2013 16:49:18 -0400 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9SKnG24027923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 28 Oct 2013 16:49:17 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 2/5] Associate target_dcache to address_space. References: <1382516855-32218-1-git-send-email-yao@codesourcery.com> <1382516855-32218-3-git-send-email-yao@codesourcery.com> <878uxkdjv3.fsf@fleche.redhat.com> <5268DAE1.6070409@codesourcery.com> Date: Mon, 28 Oct 2013 20:49:00 -0000 In-Reply-To: <5268DAE1.6070409@codesourcery.com> (Yao Qi's message of "Thu, 24 Oct 2013 16:31:29 +0800") Message-ID: <871u35azoz.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00884.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2013-10-24 Yao Qi Yao> * progspace.h (struct address_space): Declare. Yao> * target.c (target_dcache_aspace_key): New. Yao> (target_dcache): Delete. Yao> (struct target_dcache): New. Yao> (target_dcache_alloc): New function. Yao> (target_dcache_xfree): New function. Yao> (target_dcache_get): New function. Yao> (target_dcache_cleanup)): New function. Yao> (target_dcache_invalidate): Update. Yao> (memory_xfer_partial_1): Update. Yao> (initialize_targets): Initialize target_dcache_aspace_key. This is ok. And, immediately contradicting myself, I think this is an improvement regardless of whether the rest of the series goes in as-is or not. That's because it removes a state-holding global in favor of a parameterized approach. So, it would be fine by me if you wanted to push in #1 and #2. If you'd rather wait for the whole series to be done, that's also ok, as it isn't urgent. Yao> + Yao> +static void Yao> +target_dcache_cleanup (struct address_space *aspace, void *arg) Yao> +{ This one needs a (short) intro comment. Tom