From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22905 invoked by alias); 9 Jan 2014 18:15:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22894 invoked by uid 89); 9 Jan 2014 18:15:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 18:15:16 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09IFCKs028205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jan 2014 13:15:13 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09IFAO3025045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 Jan 2014 13:15:11 -0500 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion References: Date: Thu, 09 Jan 2014 18:15:00 -0000 In-Reply-To: (Iain Buclaw's message of "Thu, 9 Jan 2014 13:07:25 +0000") Message-ID: <871u0h9g41.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00244.txt.bz2 >>>>> "Iain" == Iain Buclaw writes: Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c. Iain> 2014-01-09 Iain Buclaw Iain> * d-lang.c (d_language_defn): Change macro_expansion_c to Iain> macro_expansion_no. Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn = Iain> c_value_print, /* Print a top-level value. */ Iain> default_read_var_value, /* la_read_var_value */ Iain> NULL, /* Language specific skip_trampoline. */ Iain> - "this", Iain> - basic_lookup_symbol_nonlocal, Iain> + "this", /* name_of_this */ Iain> + basic_lookup_symbol_nonlocal, Iain> basic_lookup_transparent_type, Iain> d_demangle, /* Language specific symbol demangler. */ Iain> NULL, /* Language specific Spurious change. This patch is ok with this removed. Tom