From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28444 invoked by alias); 5 May 2014 13:35:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28430 invoked by uid 89); 5 May 2014 13:35:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 05 May 2014 13:35:47 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 May 2014 14:35:43 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 5 May 2014 14:35:42 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1EF3F17D804E for ; Mon, 5 May 2014 14:36:46 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s45DZfPw2949608 for ; Mon, 5 May 2014 13:35:41 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s45DZdp4001962 for ; Mon, 5 May 2014 07:35:40 -0600 Received: from br87z6lw.de.ibm.com (sig-9-145-104-183.uk.ibm.com [9.145.104.183]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s45DZaXp001748; Mon, 5 May 2014 07:35:37 -0600 From: Andreas Arnez To: Mark Kettenis Cc: gdb-patches@sourceware.org, kevinb@redhat.com, yao@codesourcery.com Subject: Re: [RFC 02/23] Remove 'arch' field from regset structure References: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> <8738gx6bc2.fsf@br87z6lw.de.ibm.com> <201405050931.s459Vnbu027141@glazunov.sibelius.xs4all.nl> Date: Mon, 05 May 2014 13:35:00 -0000 In-Reply-To: <201405050931.s459Vnbu027141@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Mon, 5 May 2014 11:31:50 +0200 (CEST)") Message-ID: <871tw8l55j.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14050513-4966-0000-0000-00000948B518 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00042.txt.bz2 On Mon, May 05 2014, Mark Kettenis wrote: >> From: Andreas Arnez >> >> Removes the 'arch' field from the regset structure, since it >> represents the only "dynamic" data in a regset. It was referenced in >> some regset supply- and collect routines, to get access to the gdbarch >> associated with the regset. Naturally, the affected routines always >> have access to the regcache to be supplied to or collected from. Thus >> the gdbarch associated with that regcache can be used instead. >> >> gdb/ >> * regset.h (struct regset): Remove gdbarch field. >> * regset.c (regset_alloc): Drop initialization of gdbarch field. >> * nios2-linux-tdep.c (nios2_core_regset): Likewise. >> * ppcfbsd-tdep.c (ppc32_fbsd_gregset, ppc64_fbsd_gregset): >> Likewise. >> * ppc-linux-tdep.c (ppc32_linux_gregset, ppc64_linux_gregset) >> (ppc32_linux_fpregset, ppc32_linux_vrregset) >> (ppc32_linux_vsxregset): Likewise. >> * i386obsd-tdep.c (i386obsd_aout_supply_regset): Get the gdbarch >> via the regcache instead of the regset. >> * i386-tdep.c (i386_supply_gregset, i386_collect_gregset) >> (i386_supply_fpregset, i386_collect_fpregset): Likewise. >> * amd64obsd-tdep.c (amd64obsd_supply_regset): Likewise. >> * amd64-tdep.c (amd64_supply_fpregset, amd64_collect_fpregset): >> Likewise. > > > The > >> - const struct gdbarch_tdep *tdep = gdbarch_tdep (regset->arch); >> + const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); > > changes make the lines too long. I suggest changing them to: > > struct gdbarch *gdbarch = get_regcache_arch (regcache); > const struct gdbarch_tdep *tdep = gdbarch_tdep(gdbarch); Done. (Adjusted patch 02/23 with the patch below.) > Otherwise, this change is fine with me. Thanks for reviewing! -- diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index df4a3f4..1b9797a 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -2842,7 +2842,8 @@ static void amd64_supply_fpregset (const struct regset *regset, struct regcache *regcache, int regnum, const void *fpregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); gdb_assert (len == tdep->sizeof_fpregset); amd64_supply_fxsave (regcache, regnum, fpregs); @@ -2858,7 +2859,8 @@ amd64_collect_fpregset (const struct regset *regset, const struct regcache *regcache, int regnum, void *fpregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); gdb_assert (len == tdep->sizeof_fpregset); amd64_collect_fxsave (regcache, regnum, fpregs); diff --git a/gdb/amd64obsd-tdep.c b/gdb/amd64obsd-tdep.c index c5ed731..2cc0a0f 100644 --- a/gdb/amd64obsd-tdep.c +++ b/gdb/amd64obsd-tdep.c @@ -45,7 +45,8 @@ amd64obsd_supply_regset (const struct regset *regset, struct regcache *regcache, int regnum, const void *regs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); gdb_assert (len >= tdep->sizeof_gregset + I387_SIZEOF_FXSAVE); diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index de783f6..7d2363f 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -3724,7 +3724,8 @@ void i386_supply_gregset (const struct regset *regset, struct regcache *regcache, int regnum, const void *gregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); const gdb_byte *regs = gregs; int i; @@ -3748,7 +3749,8 @@ i386_collect_gregset (const struct regset *regset, const struct regcache *regcache, int regnum, void *gregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); gdb_byte *regs = gregs; int i; @@ -3770,7 +3772,8 @@ static void i386_supply_fpregset (const struct regset *regset, struct regcache *regcache, int regnum, const void *fpregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); if (len == I387_SIZEOF_FXSAVE) { @@ -3792,7 +3795,8 @@ i386_collect_fpregset (const struct regset *regset, const struct regcache *regcache, int regnum, void *fpregs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); if (len == I387_SIZEOF_FXSAVE) { diff --git a/gdb/i386obsd-tdep.c b/gdb/i386obsd-tdep.c index bc29606..7d9ba93 100644 --- a/gdb/i386obsd-tdep.c +++ b/gdb/i386obsd-tdep.c @@ -142,7 +142,8 @@ i386obsd_aout_supply_regset (const struct regset *regset, struct regcache *regcache, int regnum, const void *regs, size_t len) { - const struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (regcache)); + struct gdbarch *gdbarch = get_regcache_arch (regcache); + const struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); const gdb_byte *gregs = regs; gdb_assert (len >= tdep->sizeof_gregset + I387_SIZEOF_FSAVE);