From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8991 invoked by alias); 29 Sep 2014 10:26:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8971 invoked by uid 89); 29 Sep 2014 10:26:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 10:26:43 +0000 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8TAQWkt022631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Sep 2014 10:26:33 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8TAQVD3006159 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Sep 2014 10:26:32 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8TAQVG3004676; Mon, 29 Sep 2014 10:26:31 GMT Received: from termi.oracle.com (/10.175.164.118) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 29 Sep 2014 03:26:30 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/9] New commands `enable probe' and `disable probe'. References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-4-git-send-email-jose.marchesi@oracle.com> <83r3yyttlf.fsf@gnu.org> Date: Mon, 29 Sep 2014 10:26:00 -0000 In-Reply-To: <83r3yyttlf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Sep 2014 16:11:08 +0300") Message-ID: <871tqu91o3.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00825.txt.bz2 Hi Eli, thanks for your review. > +@kindex enable probes > +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]} Is it correct that NAME can be given only if PROVIDER is given, and OBJFILE can be given only if both NAME and PROVIDER were given? That's what the nesting of [..] suggests. Yes, that is correct. The same syntax is used in the `info probes' command, so I just kept it. > +Each argument is a regular expression, used to select probes.\n\ > +PROVIDER matches probe provider names.\n\ > +NAME matches the probe names.\n\ > +OBJECT matches the executable or shared library name.\n\ > +If you do not specify any argument then the command will disable\n\ > +all defined probes."), ^^^^^^^^ A copy/paste typo. Fixed, thanks.