From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9060 invoked by alias); 21 Oct 2014 07:58:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8996 invoked by uid 89); 21 Oct 2014 07:58:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Oct 2014 07:58:48 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XgUL7-0005Rn-Ni from Yao_Qi@mentor.com ; Tue, 21 Oct 2014 00:58:45 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Tue, 21 Oct 2014 00:58:44 -0700 From: Yao Qi To: Victor Kamensky CC: Subject: Re: [PATCH 2/5] ARM: extract_arm_insn function need to read instrs correctly in be8 case References: <1413853021-4393-1-git-send-email-victor.kamensky@linaro.org> <1413853021-4393-3-git-send-email-victor.kamensky@linaro.org> Date: Tue, 21 Oct 2014 07:58:00 -0000 In-Reply-To: <1413853021-4393-3-git-send-email-victor.kamensky@linaro.org> (Victor Kamensky's message of "Mon, 20 Oct 2014 17:56:58 -0700") Message-ID: <871tq1kgc2.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00535.txt.bz2 Victor Kamensky writes: > Fix is to change gdbarch_byte_order to gdbarch_byte_order_for_code, > when passed to extract_unsigned_integer that reads instruction. > --- > gdb/ChangeLog | 5 +++++ > gdb/arm-tdep.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index c967a93..2aef5dc 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2014-10-13 Victor Kamensky > + > + * arm-tdep.c (extract_arm_insn): use dbarch_byte_order_for_code > + to read arm instruction. > + > 2014-09-30 Don Breazeal >=20=20 > * inf-ptrace.c (inf_ptrace_follow_fork): Remove target-independent Looks good to me. We don't include the ChangeLog changes in the patch, because that will cause conflicts when applying your patch locally in the review. Instead, we include ChangeLog entries in the commit messages, see https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_co= mmit_messages --=20 Yao (=E9=BD=90=E5=B0=A7)