From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118430-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6634 invoked by alias); 17 Dec 2014 08:02:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 6622 invoked by uid 89); 17 Dec 2014 08:02:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Dec 2014 08:02:35 +0000
Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1Y19Z1-00061d-RF from Yao_Qi@mentor.com ; Wed, 17 Dec 2014 00:02:31 -0800
Received: from GreenOnly (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Wed, 17 Dec 2014 00:02:31 -0800
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/5] libthread_db: debug output should go to gdb_stdlog
References: <1418748834-27545-1-git-send-email-palves@redhat.com>	<1418748834-27545-2-git-send-email-palves@redhat.com>
Date: Wed, 17 Dec 2014 08:02:00 -0000
In-Reply-To: <1418748834-27545-2-git-send-email-palves@redhat.com> (Pedro	Alves's message of "Tue, 16 Dec 2014 16:53:50 +0000")
Message-ID: <871tnyu2k7.fsf@codesourcery.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-12/txt/msg00463.txt.bz2

Pedro Alves <palves@redhat.com> writes:

>    if (libthread_db_debug || *libthread_db_search_path)
>      {
> +      struct ui_file *file;
>        const char *library;
>=20=20
>        library =3D dladdr_to_soname (*info->td_ta_new_p);
>        if (library =3D=3D NULL)
>  	library =3D LIBTHREAD_DB_SO;
>=20=20
> -      printf_unfiltered (_("Using host libthread_db library \"%s\".\n"),
> -			 library);
> +      file =3D *libthread_db_search_path !=3D '\0' ? gdb_stdout : gdb_st=
dlog;

Nit: why don't we check libthread_db_debug instead? like:

      file =3D libthread_db_debug ? gdb_stdlog : gdb_stdout;

> +      fprintf_unfiltered (file, _("Using host libthread_db library \"%s\=
".\n"),
> +			  library);

--=20
Yao (=E9=BD=90=E5=B0=A7)