From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9504 invoked by alias); 16 Feb 2015 13:20:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9491 invoked by uid 89); 16 Feb 2015 13:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_PASS,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 16 Feb 2015 13:20:47 +0000 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1GDKiSD010672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Feb 2015 13:20:44 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id t1GDKhIF000466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 16 Feb 2015 13:20:44 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1GDKhY4004904 for ; Mon, 16 Feb 2015 13:20:43 GMT Received: from termi.oracle.com (/10.175.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Feb 2015 05:20:43 -0800 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: gdb-patches@sourceware.org Subject: Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> Date: Mon, 16 Feb 2015 13:20:00 -0000 In-Reply-To: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> (Jose E. Marchesi's message of "Mon, 2 Feb 2015 12:02:39 +0100") Message-ID: <871tlq56o3.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00360.txt.bz2 ping [Changes from V3: - Added some missing spaces after periods in the documentation patch. Spotted by Eli. - Sort ChangeLog entries so they reflect the changes in the same order than the diffs. - Use transformed tool names in the pdtrace script, which is now processed through configure. Introduce a new GDB_AC_TRANSFORM macro to avoid repeating a code idiom and use it to define both GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME in the main configure.ac. - Copyright year updated to 2015 in new files introduces by the patch series.] This patch series introduces support in GDB for a new type of probe: DTrace USDT probes. The first three patches do some changes to the existing probe.[ch] code, fixing some minor problems associated to support several probe types, having several probes of different types defined in the same object and supporting the notion of enabling and disabling probes. The rest of the patches are the implementation of the new probe type, including target support for x86_64 targets, a testsuite and documentation. Tested on x86_64-*-linux-gnu. No visible regressions. Jose E. Marchesi (9): Adapt `info probes' to support printing probes of different types. Move `compute_probe_arg' and `compile_probe_arg' to probe.c New commands `enable probe' and `disable probe'. New gdbarch functions: dtrace_parse_probe_argument, dtrace_probe_is_enabled, dtrace_enable_probe, dtrace_disable_probe. New probe type: DTrace USDT probes. Support for DTrace USDT probes in x86_64 targets. Simple testsuite for DTrace USDT probes. Documentation for DTrace USDT probes. Announce the DTrace USDT probes support in NEWS. gdb/ChangeLog | 120 ++++ gdb/Makefile.in | 4 +- gdb/NEWS | 3 + gdb/acinclude.m4 | 3 + gdb/amd64-linux-tdep.c | 148 +++++ gdb/breakpoint.c | 3 +- gdb/configure | 26 +- gdb/configure.ac | 16 +- gdb/doc/ChangeLog | 13 + gdb/doc/gdb.texinfo | 85 ++- gdb/dtrace-probe.c | 909 +++++++++++++++++++++++++++ gdb/gdbarch.c | 128 ++++ gdb/gdbarch.h | 36 ++ gdb/gdbarch.sh | 16 + gdb/probe.c | 338 +++++++++- gdb/probe.h | 18 + gdb/stap-probe.c | 123 +--- gdb/testsuite/ChangeLog | 18 + gdb/testsuite/aclocal.m4 | 1 + gdb/testsuite/configure | 62 ++ gdb/testsuite/configure.ac | 9 + gdb/testsuite/gdb.base/dtrace-probe.c | 38 ++ gdb/testsuite/gdb.base/dtrace-probe.d | 21 + gdb/testsuite/gdb.base/dtrace-probe.exp | 106 ++++ gdb/testsuite/gdb.base/stap-probe.exp | 2 +- gdb/testsuite/lib/dtrace.exp | 71 +++ gdb/testsuite/lib/pdtrace.in | 1033 +++++++++++++++++++++++++++++++ 27 files changed, 3170 insertions(+), 180 deletions(-) create mode 100644 gdb/dtrace-probe.c create mode 100644 gdb/testsuite/gdb.base/dtrace-probe.c create mode 100644 gdb/testsuite/gdb.base/dtrace-probe.d create mode 100644 gdb/testsuite/gdb.base/dtrace-probe.exp create mode 100644 gdb/testsuite/lib/dtrace.exp create mode 100755 gdb/testsuite/lib/pdtrace.in