From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4247 invoked by alias); 7 Jun 2016 15:12:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4235 invoked by uid 89); 7 Jun 2016 15:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 07 Jun 2016 15:12:05 +0000 Received: (qmail 7798 invoked by uid 0); 7 Jun 2016 15:12:02 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy5.mail.unifiedlayer.com with SMTP; 7 Jun 2016 15:12:02 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id 3rBz1t00o2f2jeq01rC2YR; Tue, 07 Jun 2016 09:12:02 -0600 X-Authority-Analysis: v=2.1 cv=ecGuId0H c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=FtBEPv93Wov3_UQprEkA:9 Received: from [65.128.48.199] (port=48380 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bAIff-0004vN-3e; Tue, 07 Jun 2016 09:11:59 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Yao Qi , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-4-git-send-email-tom@tromey.com> <86mvmywgj1.fsf@gmail.com> <8760tl6xbf.fsf@tromey.com> <9b062e13-3541-b122-2da8-1c61fe7fe55b@redhat.com> Date: Tue, 07 Jun 2016 15:12:00 -0000 In-Reply-To: <9b062e13-3541-b122-2da8-1c61fe7fe55b@redhat.com> (Pedro Alves's message of "Tue, 7 Jun 2016 15:27:20 +0100") Message-ID: <871t496nk4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bAIff-0004vN-3e X-Source-Sender: (bapiya) [65.128.48.199]:48380 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00136.txt.bz2 Pedro> Before, this would set language to language_cplus, even if the Pedro> symbol's language was Rust. [...] Pedro> However, this no longer forces C++, is that intended? I think the old code was in error. Pedro> Also, before we'd check whether gdb_demangle returned not-NULL, Pedro> before taking the language, but now several languages Pedro> return 1 even if gdb_demangle returns NULL: Sorry about that. I'll fix up the patch a bit more. Tom