From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42151 invoked by alias); 28 Sep 2016 15:23:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42125 invoked by uid 89); 28 Sep 2016 15:23:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:10.0.90.82, Hx-spam-relays-external:CMOut01, qiyaoltcgmailcom, H*r:CMOut01 X-HELO: gproxy1.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Sep 2016 15:23:14 +0000 Received: from CMOut01 (cmgw2 [10.0.90.82]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id AC33A175C7F for ; Wed, 28 Sep 2016 09:21:10 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id p3M21t0032f2jeq013M5mW; Wed, 28 Sep 2016 09:21:08 -0600 X-Authority-Analysis: v=2.1 cv=OPq0g0qB c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=pGLkceISAAAA:8 a=CvgsxPeAPLmehBKG6dwA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:47534 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bpGfP-0005YQ-Et; Wed, 28 Sep 2016 09:21:03 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [RFA 2/3] Add missing ATTRIBUTE_NORETURNs References: <1475000192-8789-1-git-send-email-tom@tromey.com> <1475000192-8789-3-git-send-email-tom@tromey.com> Date: Wed, 28 Sep 2016 17:40:00 -0000 In-Reply-To: (Yao Qi's message of "Wed, 28 Sep 2016 00:30:33 +0100") Message-ID: <871t04cap5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bpGfP-0005YQ-Et X-Source-Sender: 71-218-192-86.hlrn.qwest.net (pokyo) [71.218.192.86]:47534 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00400.txt.bz2 >>>>> "Yao" == Yao Qi writes: >> -extern void throw_max_completions_reached_error (void); >> +extern void throw_max_completions_reached_error (void) >> + ATTRIBUTE_NORETURN; Yao> Don't we need to also add ATTRIBUTE_NORETURN to the definition of Yao> throw_max_completions_reached_error? No, it's sufficient to have an attribute on a prototype, if the prototype is in scope when the definition is seen. This seems to be the normal approach in gdb, e.g., see error_no_arg. Tom