Re: [PATCH] Fix phony iconv build

Pedro Alves
2016-10-17T16:04:07Z

On 10/17/2016 04:59 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar
> Pedro> iterator into a class). The problem is that iconv_t is now exposed in
> Pedro> charset.h, while before it was only used in charset.c. gdb/charset.c,
> Pedro> under #ifdef PHONY_ICONV, does:
>
> I'm sorry about that.

No worries. Seems like no build slave is exercising this
code path.

> Pedro> So it seems the simplest is to use 'int' in the header file too.
> Pedro> Tromey, WDYT?
>
> Looks good, thanks.

Thanks, I'll push it in soon.

Thanks,
Pedro Alves