From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23968 invoked by alias); 17 Oct 2016 16:00:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23909 invoked by uid 89); 17 Oct 2016 16:00:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:69.89.20.122, H*RU:10.0.90.82, Hx-spam-relays-external:69.89.20.122, Hx-spam-relays-external:sk:gproxy9 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 17 Oct 2016 16:00:08 +0000 Received: (qmail 25642 invoked by uid 0); 17 Oct 2016 16:00:06 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy9.mail.unifiedlayer.com with SMTP; 17 Oct 2016 16:00:06 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id wfzy1t0052f2jeq01g01vR; Mon, 17 Oct 2016 10:00:02 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=GV3RC6K2C8chkGAYOCsA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:50434 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bwAKV-0005ti-EL; Mon, 17 Oct 2016 09:59:59 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Fix phony iconv build References: <1476713788-18547-1-git-send-email-palves@redhat.com> Date: Mon, 17 Oct 2016 16:00:00 -0000 In-Reply-To: <1476713788-18547-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 17 Oct 2016 15:16:28 +0100") Message-ID: <871szf3r0j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bwAKV-0005ti-EL X-Source-Sender: 174-16-143-211.hlrn.qwest.net (pokyo) [174.16.143.211]:50434 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00486.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar Pedro> iterator into a class). The problem is that iconv_t is now exposed in Pedro> charset.h, while before it was only used in charset.c. gdb/charset.c, Pedro> under #ifdef PHONY_ICONV, does: I'm sorry about that. Pedro> So it seems the simplest is to use 'int' in the header file too. Pedro> Tromey, WDYT? Looks good, thanks. Tom